From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755293AbcEaGpF (ORCPT ); Tue, 31 May 2016 02:45:05 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:55035 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbcEaGpC convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2016 02:45:02 -0400 X-AuditID: cbfee68f-f79d26d0000014f6-d2-574d32d7d170 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <574D32D7.2090902@samsung.com> Date: Tue, 31 May 2016 15:44:39 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Rob Herring , Venkat Reddy Talla Cc: MyungJoo Ham , Pawel Moll , Mark Rutland , Ian Campbell , devicetree@vger.kernel.org, Kumar Gala , linux-kernel@vger.kernel.org, Laxman Dewangan Subject: Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings References: <1464263265-20187-1-git-send-email-vreddytalla@nvidia.com> <20160527152934.GB12024@rob-hp-laptop> In-reply-to: <20160527152934.GB12024@rob-hp-laptop> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsWyRsSkQPeGkW+4wS9di/lHzrFa9L9ZyGpx 7tVKRoul+1azWFzeNYfNYun1i0wWtxtXsFlMmL6WxeL/nh3sFqvuvGdx4PJYM28No8flvl4m j5XLv7B5bFrVyebR2/yOzaNvyypGj8+b5ALYo7hsUlJzMstSi/TtErgyVl/5wlYwSbDi8dyz TA2MT3m7GDk5JARMJPY962WEsMUkLtxbz9bFyMUhJLCCUeL+3qVsMEWHrkxkgkjMYpTo3nmQ CSTBKyAo8WPyPRYQm1lAXWLSvEXMELaIxM2JNxkhbG2JZQtfM0M0P2CUWHXnBStEs5bErz83 wIpYBFQlTl86yQ5iswHF97+4AbSZg0NUIEKi+0QlSFhEwE+i40sD2BxmgTVMEi/f/gPrFQZK rNjfBdYrJHCYUeLEJA4Qm1PAWOLCxi0sIA0SAn/ZJe6fmcUOsUxA4tvkQywgCyQEZCU2HWCG +FJS4uCKGywTGMVnIfltFpLfZiH5bRaS3xYwsqxiFE0tSC4oTkovMtYrTswtLs1L10vOz93E CIzs0/+e9e9gvHvA+hCjAAejEg8vxwSfcCHWxLLiytxDjKZAF01klhJNzgemj7ySeENjMyML UxNTYyNzSzMlcd6FUj+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTDylF5xDhM/G1olqyow lbN3M/eGhkqB9oBvf6PbrptX+pzy0j2T9P/c+4cH48x54n4HX2nhWfx38bRDs1YfnSfNohzq tej55WVFJfabbrsbf1rQWjnDfWJO8qN2zdJQMb70JXUPm3L+ah9o2W543GBqbMAyCcVHHnZn dtqde1THHiB+0GHCXl4lluKMREMt5qLiRAAc5DOF5wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42I5/e+xoO51I99wg4VnzC3mHznHatH/ZiGr xblXKxktlu5bzWJxedccNoul1y8yWdxuXMFmMWH6WhaL/3t2sFusuvOexYHLY828NYwel/t6 mTxWLv/C5rFpVSebR2/zOzaPvi2rGD0+b5ILYI9qYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneO NzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMATpQSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5v SBBcj5EBGkhYw5hx7PBWtoJ7AhX/lz5ha2DcyNvFyMkhIWAicejKRCYIW0ziwr31bF2MXBxC ArMYJbp3HgRL8AoISvyYfI+li5GDg1lAXuLIpWyQMLOAusSkeYuYIeofMEqsuvOCFaJeS+LX nxuMIDaLgKrE6Usn2UFsNqD4/hc32EDmiApESHSfqAQJiwj4SXR8aQCbwyywhkni5dt/YL3C QIkV+7vAeoUEDjNKnJjEAWJzChhLXNi4hWUCI9CVCOfNQjhvFpLzFjAyr2KUSC1ILihOSs81 zEst1ytOzC0uzUvXS87P3cQITgXPpHYwHtzlfohRgINRiYc3YZJPuBBrYllxZe4hRgkOZiUR Xn9d33Ah3pTEyqrUovz4otKc1OJDjKZA/01klhJNzgemqbySeENjEzMjSyNzQwsjY3Mlcd7H /9eFCQmkJ5akZqemFqQWwfQxcXBKNTCunFX4ftpGDd9rRuKS6TqHNzxk863XVHLLSc2+Vz9l /s5Plg/a8s40L/29Z/8FzatyN/+8fZL+23jjd+XCqj7lcDWJ230HW7UaK2f3XT3tJyikPWna q6QF9eFGE2UrtTp5L2grHGl1zlLf47xpekpm4vGuJ3skzqfdfvo+td/Xkn3r0rqFud+VWIoz Eg21mIuKEwEegUJWGwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 05월 28일 00:29, Rob Herring wrote: > On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: >> Add the support for Device tree bindings of extcon-gpio driver. >> The extcon-gpio device tree node must include the both 'extcon-id' and >> 'gpios' property. > > I think extcon bindings are a mess in general... > >> For example: >> usb_cable: extcon-gpio-0 { >> compatible = "extcon-gpio"; >> extcon-id = ; >> gpios = <&gpio6 1 GPIO_ACTIVE_HIGH>; >> } >> ta_cable: extcon-gpio-1 { >> compatible = "extcon-gpio"; >> extcon-id = ; >> gpios = <&gpio3 2 GPIO_ACTIVE_LOW>; >> debounce-ms = <50>; /* 50 millisecond */ >> wakeup-source; >> } > > This is all 1 logical connector, the USB connector. Why are you > describing cables? Those are not part of the h/w and are dynamic. > Describe this as a connector which is one thing (i.e. node). Use a > compatible string that reflects the type of connector > (usb-microab-connector), not the driver you want to use. Then define > GPIO lines needed to provide state information like VBus, ID, charger > modes and control lines like soft connect (D+ pullup enable), VBus > enable, etc. You're right. The extcon-gpio driver will not use the "extcon-gpio" raw compatible. As you commented[1], the each connector will have the unique name to use the extcon-gpio.c driver. [1] https://lkml.org/lkml/2015/10/21/906 For example, The extcon-gpio.c driver may have the different name including the h/w information according to the kind of external connector. static const struct of_device_id gpio_extcon_of_match[] = { { .compatible = "extcon-chg-sdp", /* SDP charger connector */ .data = EXTCON_CHG_SDP_DATA, }, { .compatible = "extcon-chg-dcp", /* DCP charger connector */ .data = EXTCON_CHG_DCP_DATA, }, { .compatible = "extcon-jack-microphone", /* Microphone jack connector */ .data = EXTCON_JACK_MICROPHONE_DATA, }, { .compatible = "extcon-disp-hdmi", /* HDMI connector*/ .data = EXTCON_DISP_HDMI_DATA, }, ...... }; Thanks, Chanwoo Choi