From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755786AbcEaIDx (ORCPT ); Tue, 31 May 2016 04:03:53 -0400 Received: from mail-ph.de-nserver.de ([85.158.179.214]:14337 "EHLO mail-ph.de-nserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755416AbcEaIDo (ORCPT ); Tue, 31 May 2016 04:03:44 -0400 X-Fcrdns: No Subject: Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) To: Dave Chinner References: <20160516010602.GA24980@bfoster.bfoster> <57420A47.2000700@profihost.ag> <20160522213850.GE26977@dastard> <574BEA84.3010206@profihost.ag> <20160530223657.GP26977@dastard> <20160531010724.GA9616@bbox> <20160531025509.GA12670@dastard> <20160531035904.GA17371@bbox> <20160531060712.GC12670@dastard> <574D2B1E.2040002@profihost.ag> <20160531073119.GD12670@dastard> Cc: Minchan Kim , Brian Foster , "xfs@oss.sgi.com" , linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Stefan Priebe - Profihost AG Message-ID: <574D455D.8050101@profihost.ag> Date: Tue, 31 May 2016 10:03:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160531073119.GD12670@dastard> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-User-Auth: Auth by hostmaster@profihost.com through 185.39.223.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 31.05.2016 um 09:31 schrieb Dave Chinner: > On Tue, May 31, 2016 at 08:11:42AM +0200, Stefan Priebe - Profihost AG wrote: >>> I'm half tempted at this point to mostly ignore this mm/ behavour >>> because we are moving down the path of removing buffer heads from >>> XFS. That will require us to do different things in ->releasepage >>> and so just skipping dirty pages in the XFS code is the best thing >>> to do.... >> >> does this change anything i should test? Or is 4.6 still the way to go? > > Doesn't matter now - the warning will still be there on 4.6. I think > you can simply ignore it as the XFS code appears to be handling the > dirty page that is being passed to it correctly. We'll work out what > needs to be done to get rid of the warning for this case, wether it > be a mm/ change or an XFS change. So is it OK to remove the WARN_ONCE in kernel code? So i don't get alarms from our monitoring systems for the trace. Stefan > > Cheers, > > Dave. >