From: Purna Chandra Mandal <purna.mandal@microchip.com>
To: Harvey Hunt <harvey.hunt@imgtec.com>, <linux-kernel@vger.kernel.org>
Cc: <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>,
Joshua Henderson <digitalpeer@digitalpeer.com>,
Joshua Henderson <joshua.henderson@microchip.com>
Subject: Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().
Date: Thu, 2 Jun 2016 14:49:44 +0530 [thread overview]
Message-ID: <574FFA30.1000507@microchip.com> (raw)
In-Reply-To: <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com>
On 06/02/2016 02:45 PM, Harvey Hunt wrote:
> Hi Purna,
>
> On 02/06/16 06:20, Purna Chandra Mandal wrote:
>> Early clock API pic32_get_pbclk() is defined in early_clk.c and
>> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
>> set, early_clk.c isn't compiled and so a linker error is reported
>> while referring the API from time.c.
>
> Maybe "early_clk.c isn't compiled and so time.c fails to link"?
>
ack.
>>
>> Fix it by compiling early_clk.c always. Also sort files in
>> alphabetical order.
>>
>> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
>> Cc: Ralf Baechle <ralf@linux-mips.org>
>> Cc: linux-mips@linux-mips.org
>> Cc: Joshua Henderson <digitalpeer@digitalpeer.com>
>>
>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>>
>> ---
>>
>> arch/mips/pic32/pic32mzda/Makefile | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile
>> index 4a4c272..c286496 100644
>> --- a/arch/mips/pic32/pic32mzda/Makefile
>> +++ b/arch/mips/pic32/pic32mzda/Makefile
>> @@ -2,8 +2,7 @@
>> # Joshua Henderson, <joshua.henderson@microchip.com>
>> # Copyright (C) 2015 Microchip Technology, Inc. All rights reserved.
>> #
>> -obj-y := init.o time.o config.o
>> +obj-y := config.o early_clk.o init.o time.o
>>
>> obj-$(CONFIG_EARLY_PRINTK) += early_console.o \
>> - early_pin.o \
>> - early_clk.o
>> + early_pin.o
>>
>
> Perhaps add:
>
> Reported-by: Harvey Hunt <harvey.hunt@imgtec.com>
>
> Thanks for fixing this,
>
> Reviewed-by: Harvey Hunt <harvey.hunt@imgtec.com>
>
Thanks Harvey.
> Thanks,
>
> Harvey
prev parent reply other threads:[~2016-06-02 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 5:20 [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk() Purna Chandra Mandal
2016-06-02 9:15 ` Harvey Hunt
2016-06-02 9:19 ` Purna Chandra Mandal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574FFA30.1000507@microchip.com \
--to=purna.mandal@microchip.com \
--cc=digitalpeer@digitalpeer.com \
--cc=harvey.hunt@imgtec.com \
--cc=joshua.henderson@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).