From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932706AbcFBKNv (ORCPT ); Thu, 2 Jun 2016 06:13:51 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:40117 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932306AbcFBKNt (ORCPT ); Thu, 2 Jun 2016 06:13:49 -0400 Subject: Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule To: David Miller , References: <1464264006-26627-1-git-send-email-eladkan@mellanox.com> <20160529.223542.1386340561946869732.davem@davemloft.net> CC: , , , , "stable@vger.kernel.org" Newsgroups: gmane.linux.kernel,gmane.linux.network From: Vineet Gupta Message-ID: <575006CA.6070705@synopsys.com> Date: Thu, 2 Jun 2016 15:43:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160529.223542.1386340561946869732.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.197.158] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 30 May 2016 11:05 AM, David Miller wrote: > From: Elad Kanfi > Date: Thu, 26 May 2016 15:00:06 +0300 > >> From: Elad Kanfi >> >> Since NAPI works by shutting down event interrupts when theres >> work and turning them on when theres none, the net driver must >> make sure that interrupts are disabled when it reschedules polling. >> By calling napi_reschedule, the driver switches to polling mode, >> therefor there should be no interrupt interference. >> Any received packets will be handled in nps_enet_poll by polling the HW >> indication of received packet until all packets are handled. >> >> Signed-off-by: Elad Kanfi >> Acked-by: Noam Camus > > Applied. > ARC osci platform in 4.6 currently have broken networking. This needs a stable backport to 4.6 Upstream 86651650d16a359e4 ("net: nps_enet: Disable interrupts before napi reschedule") Thx, -Vineet