From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933100AbcFBRWJ (ORCPT ); Thu, 2 Jun 2016 13:22:09 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34294 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932967AbcFBRWG (ORCPT ); Thu, 2 Jun 2016 13:22:06 -0400 Subject: Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. To: Gerd Hoffmann References: <1464817421-8519-1-git-send-email-kraxel@redhat.com> <1464817421-8519-2-git-send-email-kraxel@redhat.com> <574F5881.4060008@gmail.com> <1464849936.24775.33.camel@redhat.com> <4e72ae37-a018-a17d-6a58-8450db58d1c7@broadcom.com> <57506351.3060706@broadcom.com> <1464887569.24775.123.camel@redhat.com> Cc: Ray Jui , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Eric Anholt , Ray Jui , Scott Branden , Russell King , Catalin Marinas , Will Deacon , "open list:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , "moderated list:ARM SUB-ARCHITECTURES" , open list From: Scott Branden Message-ID: <57506B31.2010600@broadcom.com> Date: Thu, 2 Jun 2016 10:21:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1464887569.24775.123.camel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-06-02 10:12 AM, Gerd Hoffmann wrote: >> There is no need to add ARCH_BCM though? > > There are Makefile(s) with > > obj-$(CONFIG_ARCH_BCM) += bcm/ > > in drivers/pinctrl for example, maybe more, didn't check the whole tree. > > So without ARCH_BCM some drivers are dropped from the build ... I see that now. Quite bizarre how the NS2 pinctl driver (used on a arm64 SoC) gets built right now.... Yes, adding the select with hidden option seems like what needs to be done. The ARM Maintainers did not like multi-level ARCH_BCM being added in the arm64 Kconfig previously so we dropped it. > > cheers, > Gerd > Thanks, Scott