From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964900Ab2KUVUp (ORCPT ); Wed, 21 Nov 2012 16:20:45 -0500 Received: from ogre.sisk.pl ([193.178.161.156]:58895 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964856Ab2KUVUn convert rfc822-to-8bit (ORCPT ); Wed, 21 Nov 2012 16:20:43 -0500 From: "Rafael J. Wysocki" To: Joe Perches Cc: Jan =?ISO-8859-1?Q?H=2E_Sch=F6nherr?= , Daniel J Blueman , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] acpi: Fix logging when no pci_irq is allocated Date: Wed, 21 Nov 2012 22:25:12 +0100 Message-ID: <5752160.0Aavql38JJ@vostro.rjw.lan> User-Agent: KMail/4.9.3 (Linux/3.7.0-rc6; KDE/4.9.3; x86_64; ; ) In-Reply-To: <1353531235.24807.39.camel@joe-AO722> References: <1353487401-10279-1-git-send-email-daniel@numascale-asia.com> <1483298.SPL34HcZVJ@vostro.rjw.lan> <1353531235.24807.39.camel@joe-AO722> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, November 21, 2012 12:53:55 PM Joe Perches wrote: > On Wed, 2012-11-21 at 21:50 +0100, Rafael J. Wysocki wrote: > > On Wednesday, November 21, 2012 05:46:04 AM Joe Perches wrote: > > > On Wed, 2012-11-21 at 16:43 +0800, Daniel J Blueman wrote: > > > > Previously a new line is implicitly added in the no GSI case: > > > > > > > > [ 7.185182] pci 0001:00:12.0: can't derive routing for PCI INT A > > > > [ 7.191352] pci 0001:00:12.0: PCI INT A: no GSI > > > > [ 7.195956] - using ISA IRQ 10 > > > > > > > > The code thus prints a blank line where no legacy IRQ is available: > > > > > > > > [ 1.650124] pci 0000:00:14.0: can't derive routing for PCI INT A > > > > [ 1.650126] pci 0000:00:14.0: PCI INT A: no GSI > > > > [ 1.650126] > > > > [ 1.650180] pci 0000:00:14.0: can't derive routing for PCI INT A > > > > > > > > Fix this by making the newline explicit and removing the superfluous > > > > one. > > > > > > This breaks the logging code below it when there is an ISA irq. > > > > > > The below works, but is a workaround for a defect in the printk > > > subsystem introduced by a logging change that will be fixed in > > > a near future release. > > > > What exactly do you mean by "near future"? > > I mean Jan Schönherr's patches that should fix this are > likely to be picked up one day. > > https://lkml.org/lkml/2012/11/13/678 Till then, we need the patch you sent, right? And it won't hurt to apply it anyway? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.