* [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID
@ 2021-02-04 8:33 You-Sheng Yang
2021-02-04 15:13 ` Srinivas Pandruvada
2021-02-08 16:00 ` Srinivas Pandruvada
0 siblings, 2 replies; 5+ messages in thread
From: You-Sheng Yang @ 2021-02-04 8:33 UTC (permalink / raw)
To: Srinivas Pandruvada, Jiri Kosina, Benjamin Tissoires,
You-Sheng Yang, Kai-Heng Feng
Cc: linux-input, linux-kernel
Added Tiger Lake H PCI device ID to the supported device list.
Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
---
drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 +
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
index 1fb294ca463e..21b0e6123754 100644
--- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h
+++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
@@ -27,6 +27,7 @@
#define CMP_H_DEVICE_ID 0x06FC
#define EHL_Ax_DEVICE_ID 0x4BB3
#define TGL_LP_DEVICE_ID 0xA0FC
+#define TGL_H_DEVICE_ID 0x43FC
#define REVISION_ID_CHT_A0 0x6
#define REVISION_ID_CHT_Ax_SI 0x0
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
index c6d48a8648b7..6dea657b7b15 100644
--- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
+++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
@@ -37,6 +37,7 @@ static const struct pci_device_id ish_pci_tbl[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, CMP_H_DEVICE_ID)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, EHL_Ax_DEVICE_ID)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_LP_DEVICE_ID)},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_H_DEVICE_ID)},
{0, }
};
MODULE_DEVICE_TABLE(pci, ish_pci_tbl);
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID
2021-02-04 8:33 [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID You-Sheng Yang
@ 2021-02-04 15:13 ` Srinivas Pandruvada
2021-02-05 3:51 ` You-Sheng Yang
2021-02-08 16:00 ` Srinivas Pandruvada
1 sibling, 1 reply; 5+ messages in thread
From: Srinivas Pandruvada @ 2021-02-04 15:13 UTC (permalink / raw)
To: You-Sheng Yang, Jiri Kosina, Benjamin Tissoires, Kai-Heng Feng
Cc: linux-input, linux-kernel
On Thu, 2021-02-04 at 16:33 +0800, You-Sheng Yang wrote:
> Added Tiger Lake H PCI device ID to the supported device list.
>
> Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
Did you get chance to verify on a platform?
Do you see sensors enumerated in /sys/bus/iio?
Thanks,
Srinivas
> ---
> drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 +
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h
> b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
> index 1fb294ca463e..21b0e6123754 100644
> --- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h
> +++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
> @@ -27,6 +27,7 @@
> #define CMP_H_DEVICE_ID 0x06FC
> #define EHL_Ax_DEVICE_ID 0x4BB3
> #define TGL_LP_DEVICE_ID 0xA0FC
> +#define TGL_H_DEVICE_ID 0x43FC
>
> #define REVISION_ID_CHT_A0 0x6
> #define REVISION_ID_CHT_Ax_SI 0x0
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index c6d48a8648b7..6dea657b7b15 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -37,6 +37,7 @@ static const struct pci_device_id ish_pci_tbl[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CMP_H_DEVICE_ID)},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, EHL_Ax_DEVICE_ID)},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_LP_DEVICE_ID)},
> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_H_DEVICE_ID)},
> {0, }
> };
> MODULE_DEVICE_TABLE(pci, ish_pci_tbl);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID
2021-02-04 15:13 ` Srinivas Pandruvada
@ 2021-02-05 3:51 ` You-Sheng Yang
0 siblings, 0 replies; 5+ messages in thread
From: You-Sheng Yang @ 2021-02-05 3:51 UTC (permalink / raw)
To: Srinivas Pandruvada, Jiri Kosina, Benjamin Tissoires, Kai-Heng Feng
Cc: linux-input, linux-kernel
On 2/4/21 11:13 PM, Srinivas Pandruvada wrote:
> On Thu, 2021-02-04 at 16:33 +0800, You-Sheng Yang wrote:
>> Added Tiger Lake H PCI device ID to the supported device list.
>>
>> Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
> Did you get chance to verify on a platform?
> Do you see sensors enumerated in /sys/bus/iio?
Yes,
[ 2.485650] ish-hid {33AECD58-B679-4E54-9BD9-A04D34F0C226}:
[hid-ish]: enum_devices_done OK, num_hid_devices=3
[ 2.497337] hid-generic 001F:8087:0AC2.0003: hidraw2: <UNKNOWN> HID
v2.00 Device [hid-ishtp 8087:0AC2] on
[ 2.506945] hid-generic 001F:8087:0AC2.0004: hidraw3: <UNKNOWN> HID
v2.00 Device [hid-ishtp 8087:0AC2] on
[ 2.512127] hid-generic 001F:8087:0AC2.0005: hidraw4: <UNKNOWN> HID
v2.00 Device [hid-ishtp 8087:0AC2] on
$ ls /sys/bus/iio/devices/
iio:device0 iio:device1 trigger0 trigger1
One of them is an ambient light sensor, and it works only with this
patch applied.
Thanks,
You-Sheng Yang
> Thanks,
> Srinivas
>
>> ---
>> drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 +
>> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h
>> b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
>> index 1fb294ca463e..21b0e6123754 100644
>> --- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h
>> +++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
>> @@ -27,6 +27,7 @@
>> #define CMP_H_DEVICE_ID 0x06FC
>> #define EHL_Ax_DEVICE_ID 0x4BB3
>> #define TGL_LP_DEVICE_ID 0xA0FC
>> +#define TGL_H_DEVICE_ID 0x43FC
>>
>> #define REVISION_ID_CHT_A0 0x6
>> #define REVISION_ID_CHT_Ax_SI 0x0
>> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
>> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
>> index c6d48a8648b7..6dea657b7b15 100644
>> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
>> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
>> @@ -37,6 +37,7 @@ static const struct pci_device_id ish_pci_tbl[] = {
>> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CMP_H_DEVICE_ID)},
>> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, EHL_Ax_DEVICE_ID)},
>> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_LP_DEVICE_ID)},
>> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_H_DEVICE_ID)},
>> {0, }
>> };
>> MODULE_DEVICE_TABLE(pci, ish_pci_tbl);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID
2021-02-04 8:33 [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID You-Sheng Yang
2021-02-04 15:13 ` Srinivas Pandruvada
@ 2021-02-08 16:00 ` Srinivas Pandruvada
2021-02-09 9:27 ` Jiri Kosina
1 sibling, 1 reply; 5+ messages in thread
From: Srinivas Pandruvada @ 2021-02-08 16:00 UTC (permalink / raw)
To: You-Sheng Yang, Jiri Kosina, Benjamin Tissoires, Kai-Heng Feng
Cc: linux-input, linux-kernel
On Thu, 2021-02-04 at 16:33 +0800, You-Sheng Yang wrote:
> Added Tiger Lake H PCI device ID to the supported device list.
>
> Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 +
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h
> b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
> index 1fb294ca463e..21b0e6123754 100644
> --- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h
> +++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h
> @@ -27,6 +27,7 @@
> #define CMP_H_DEVICE_ID 0x06FC
> #define EHL_Ax_DEVICE_ID 0x4BB3
> #define TGL_LP_DEVICE_ID 0xA0FC
> +#define TGL_H_DEVICE_ID 0x43FC
>
> #define REVISION_ID_CHT_A0 0x6
> #define REVISION_ID_CHT_Ax_SI 0x0
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index c6d48a8648b7..6dea657b7b15 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -37,6 +37,7 @@ static const struct pci_device_id ish_pci_tbl[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CMP_H_DEVICE_ID)},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, EHL_Ax_DEVICE_ID)},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_LP_DEVICE_ID)},
> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_H_DEVICE_ID)},
> {0, }
> };
> MODULE_DEVICE_TABLE(pci, ish_pci_tbl);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID
2021-02-08 16:00 ` Srinivas Pandruvada
@ 2021-02-09 9:27 ` Jiri Kosina
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2021-02-09 9:27 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: You-Sheng Yang, Benjamin Tissoires, Kai-Heng Feng, linux-input,
linux-kernel
On Mon, 8 Feb 2021, Srinivas Pandruvada wrote:
> > Added Tiger Lake H PCI device ID to the supported device list.
> >
> > Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-09 9:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 8:33 [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID You-Sheng Yang
2021-02-04 15:13 ` Srinivas Pandruvada
2021-02-05 3:51 ` You-Sheng Yang
2021-02-08 16:00 ` Srinivas Pandruvada
2021-02-09 9:27 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).