From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751787AbcFFJjg (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jun 2016 05:39:36 -0400
Received: from foss.arm.com ([217.140.101.70]:35103 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751025AbcFFJjf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jun 2016 05:39:35 -0400
Subject: Re: [PATCH] mailbox: mailbox-test: set tdev->signal to NULL after
 freeing
To: Lee Jones <lee.jones@linaro.org>, Jassi Brar <jaswinder.singh@linaro.org>
References: <1464106324-25005-1-git-send-email-sudeep.holla@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>, linux-kernel@vger.kernel.org,
        Jassi Brar <jassisinghbrar@gmail.com>
From: Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <575544D4.6020706@arm.com>
Date: Mon, 6 Jun 2016 10:39:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1464106324-25005-1-git-send-email-sudeep.holla@arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jassi, Lee,

On 24/05/16 17:12, Sudeep Holla wrote:
> tdev->signal is not set NULL after it's freed. This will cause random
> exceptions when the stale pointer is accessed after tdev->signal is
> freed. Also, since tdev->signal allocation is skipped the next time
> it's written, this leads to continuous fault finally leading to the
> total death of the system.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>

Can you review this ?

-- 
Regards,
Sudeep