From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753864AbcFGGtj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 02:49:39 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:4583 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753707AbcFGGti (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 02:49:38 -0400
X-PGP-Universal: processed;
	by hqnvupgp08.nvidia.com on Mon, 06 Jun 2016 23:47:21 -0700
Message-ID: <57566B83.3060008@nvidia.com>
Date: Tue, 7 Jun 2016 12:06:51 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
        <linux-kernel@vger.kernel.org>
CC: Linus Walleij <linus.walleij@linaro.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 6/9] pinctrl: palmas: make it explicitly non-modular
References: <1465267388-17884-1-git-send-email-paul.gortmaker@windriver.com> <1465267388-17884-7-git-send-email-paul.gortmaker@windriver.com>
In-Reply-To: <1465267388-17884-7-git-send-email-paul.gortmaker@windriver.com>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: DRHKMAIL101.nvidia.com (10.25.59.15) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Tuesday 07 June 2016 08:13 AM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> config PINCTRL_PALMAS
>          bool "Pinctrl driver for the PALMAS Series MFD devices"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>


Let's make the driver as tristate.

tristate "Pinctrl driver for the PALMAS Series MFD devices"