From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754573AbcFGLsH (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 07:48:07 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:5637 "EHLO
	hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754274AbcFGLsF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 07:48:05 -0400
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Tue, 07 Jun 2016 04:44:56 -0700
Message-ID: <5756B174.5090909@nvidia.com>
Date: Tue, 7 Jun 2016 17:05:16 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Rhyland Klein <rklein@nvidia.com>,
        Thierry Reding <thierry.reding@gmail.com>
CC: Stephen Warren <swarren@wwwdotorg.org>, Jon Hunter <jonathanh@nvidia.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Andrew Bresticker <abrestic@chromium.org>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM64: boot: dts: Add regulators for Tegra210 Smaug
References: <1464985365-11612-1-git-send-email-rklein@nvidia.com> <57551AAD.2020805@nvidia.com> <b28b44d9-7f3e-c1bb-7df8-238191ab1941@nvidia.com>
In-Reply-To: <b28b44d9-7f3e-c1bb-7df8-238191ab1941@nvidia.com>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: BGMAIL103.nvidia.com (10.25.59.12) To bgmail102.nvidia.com
 (10.25.59.11)
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Tuesday 07 June 2016 03:22 AM, Rhyland Klein wrote:
> On 6/6/2016 2:39 AM, Laxman Dewangan wrote:
>> On Saturday 04 June 2016 01:52 AM, Rhyland Klein wrote:
>>> +					regulator-disable-ramp-delay = <4080>;
>>> +					regulator-ramp-delay = <27500>;
>>> +					regulator-ramp-delay-scale = <300>;
>> There is no disable-ramp-delay in mainline.
>> Please use the correct value for property as:
>>                                        regulator-ramp-delay = <9000>;
>>                                        maxim,ramp-rate-setting = <27500>;
>>
>>
>> instead of regulator-ramp-delay and regulator-ramp-delay-scale.
>> The property differs from downstream.
>>
>> regulator-ramp-delay is what you see in platform and
>> maxim,ramp-rate-setting is what you want in register.
> Where does "<9000>" come from in the above comment? It looks like
> maxim,ramp-rate-setting sets the slew rate, and regulator-ramp-delay
> will as well, but will be ignored if maxim,ramp-delay-setting is set. So
> does it ever make sense to have both defined for a regulator? And if
> not, should max77620 regulators just use the maxim property and not the
> regulator core property?
>


9000uV/us is what measured ramp delay in the platform after setting the 
device register to 27500uV/us.

This is derived from our downstream table as ramp-delay *100/scale
so here 27500 *100/300 is approx to 9000.

This is used when your measured is varied from register configuration 
which is true in most of our platform.
If your platform does not have diff then please provide 
regulator-ramp-delay only with what you measured.