From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932767AbcFGN3t (ORCPT ); Tue, 7 Jun 2016 09:29:49 -0400 Received: from foss.arm.com ([217.140.101.70]:44362 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973AbcFGN3r (ORCPT ); Tue, 7 Jun 2016 09:29:47 -0400 Subject: Re: [PATCH 3/3] firmware: scpi: add device power domain support using genpd To: "Jon Medhurst (Tixy)" References: <1465228439-13457-1-git-send-email-sudeep.holla@arm.com> <1465228439-13457-4-git-send-email-sudeep.holla@arm.com> <1465305537.2833.28.camel@linaro.org> Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Mathieu Poirier , Suzuki K Poulose , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-pm@vger.kernel.org From: Sudeep Holla Organization: ARM Message-ID: <5756CC48.8050001@arm.com> Date: Tue, 7 Jun 2016 14:29:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465305537.2833.28.camel@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/16 14:18, Jon Medhurst (Tixy) wrote: > On Mon, 2016-06-06 at 16:53 +0100, Sudeep Holla wrote: >> This patch hooks up the support for device power domain provided by >> SCPI using the Linux generic power domain infrastructure. >> >> Cc: "Rafael J. Wysocki" >> Cc: Kevin Hilman >> Cc: Ulf Hansson >> Cc: linux-pm@vger.kernel.org >> Signed-off-by: Sudeep Holla >> --- >> drivers/firmware/Kconfig | 8 +++ >> drivers/firmware/Makefile | 1 + >> drivers/firmware/scpi_pd.c | 152 +++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 161 insertions(+) >> create mode 100644 drivers/firmware/scpi_pd.c >> >> Hi, >> >> Since most of the power controller drivers are place in drivers/soc/, >> I am not sure where to put this SCPI power domain code as it can be used >> on multiple SoC. I have placed it in drivers/firmware temporarily for >> review. Please suggest the most apt place to put this driver. >> >> Regards, >> Sudeep >> >> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig >> index 41abdc54815e..80c963c60f13 100644 >> --- a/drivers/firmware/Kconfig >> +++ b/drivers/firmware/Kconfig >> @@ -27,6 +27,14 @@ config ARM_SCPI_PROTOCOL >> This protocol library provides interface for all the client drivers >> making use of the features offered by the SCP. >> >> +config ARM_SCPI_POWER_DOMAIN >> + tristate "SCPI power domain driver" >> + depends on (ARM_SCPI_PROTOCOL && PM) || COMPILE_TEST >> + select PM_GENERIC_DOMAINS_OF > Actually I had something like below before and changed it before posting. config ARM_SCPI_POWER_DOMAIN tristate "SCPI power domain driver" depends on ARM_SCPI_PROTOCOL || COMPILE_TEST select PM_GENERIC_DOMAINS if PM select PM_GENERIC_DOMAINS_OF if PM The idea was to allow compilation of this even if PM was disabled. > That select doesn't work for me and gives: > > warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF) > > Followed by link errors due to missing symbols. > > I think you need to select PM_GENERIC_DOMAINS as well. I agree, that's exactly what I had before. > Or perhaps just instead of, as PM_GENERIC_DOMAINS_OF defaults 'y' and isn't user > selectable. From kernel/power/Kconfig ... > Makes sense, I am fine with that too. -- Regards, Sudeep