From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755620AbcFGP0J (ORCPT ); Tue, 7 Jun 2016 11:26:09 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:46513 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754323AbcFGPZy (ORCPT ); Tue, 7 Jun 2016 11:25:54 -0400 Subject: Re: [PATCH v2 0/2] net: ethernet: ti: cpsw: delete rx_descs property To: Ivan Khoronzhuk , , References: <1465307976-12235-1-git-send-email-ivan.khoronzhuk@linaro.org> CC: , , , , , , , , , , From: Schuyler Patton Message-ID: <5756E7A8.6090703@ti.com> Date: Tue, 7 Jun 2016 10:26:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1465307976-12235-1-git-send-email-ivan.khoronzhuk@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 06/07/2016 08:59 AM, Ivan Khoronzhuk wrote: > There is no reason in rx_descs property because davinici_cpdma > driver splits pool of descriptors equally between tx and rx channels. > So, this patch series makes driver to use available number of > descriptors for rx channels. I agree with the idea of consolidating how the descriptors are defined because of the two variable components, number and size of the pool can be confusing to end users. I would like to request to change how it is being proposed here. I think the number of descriptors should be left in the device tree source file as is and remove the BD size variable and have the driver calculate the size of the pool necessary to support the descriptor request. From an user perspective it is easier I think to be able to list the number of descriptors necessary vs. the size of the pool. Since the patch series points out how it is used so in the driver so to make that consistent is perhaps change rx_descs to total_descs. Regards, Schuyler > > Based on master branch > > Since v1: > - separate device tree and driver patches > - return number of rx buffers from cpdma driver > > Ivan Khoronzhuk (2): > net: ethernet: ti: cpsw: remove rx_descs property > Documentation: DT: cpsw: remove rx_descs property > > Documentation/devicetree/bindings/net/cpsw.txt | 1 - > arch/arm/boot/dts/am33xx.dtsi | 1 - > arch/arm/boot/dts/am4372.dtsi | 1 - > arch/arm/boot/dts/dm814x.dtsi | 1 - > arch/arm/boot/dts/dra7.dtsi | 1 - > drivers/net/ethernet/ti/cpsw.c | 13 +++---------- > drivers/net/ethernet/ti/cpsw.h | 1 - > drivers/net/ethernet/ti/davinci_cpdma.c | 6 ++++++ > drivers/net/ethernet/ti/davinci_cpdma.h | 1 + > 9 files changed, 10 insertions(+), 16 deletions(-) >