From: Sean Anderson <sean.anderson@seco.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Balaji Prakash J <bjagadee@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Robert Hancock <robert.hancock@calian.com>,
Baruch Siach <baruch@tkos.co.il>
Subject: Re: [PATCH v2 4/7] usb: dwc3: Program GFLADJ
Date: Thu, 27 Jan 2022 11:45:25 -0500 [thread overview]
Message-ID: <5756b3c4-02eb-8156-f973-bd592fa139ef@seco.com> (raw)
In-Reply-To: <87mtji7onx.fsf@kernel.org>
On 1/26/22 5:53 AM, Felipe Balbi wrote:
>
> Hi,
>
> Sean Anderson <sean.anderson@seco.com> writes:
>
>> On 1/24/22 9:11 PM, Thinh Nguyen wrote:
>>>>>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>>>>>> index 5214daceda86..883e119377f0 100644
>>>>>> --- a/drivers/usb/dwc3/core.c
>>>>>> +++ b/drivers/usb/dwc3/core.c
>>>>>> @@ -348,7 +348,7 @@ static void dwc3_frame_length_adjustment(struct dwc3 *dwc)
>>>>>> static void dwc3_ref_clk_period(struct dwc3 *dwc)
>>>>>> {
>>>>>> u32 reg;
>>>>>> - unsigned long rate, period;
>>>>>> + unsigned long decr, fladj, rate, period;
>>>>>
>>>>> Minor style nit: Felipe prefers to keep the declaration on separate
>>>>> lines, let's keep it consistent with the rest in this driver.
>>>>
>>>> So
>>>>
>>>> unsigned int decr;
>>>> unsigned int fladj;
>>>> unsigned int rate;
>>>> unsigned int period;
>>>>
>>>> ?
>>>>
>>>> Frankly that seems rather verbose.
>>>
>>> A couple of the benefits of having it like this is to help with viewing
>>> git-blame if we introduce new variables and help with backporting fix
>>> patch a bit simpler. Mainly I'm just following Felipe's style and keep
>>> it consistent in this driver, but I don't think it's a big deal.
>>
>> *shrug*
>>
>> If it's the subsystem style I will rewrite it.
>>
>> (btw is this documented anywhere for future contributors?)
>
> https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
>
> "To this end, use just one data declaration per line (no commas for
> multiple data declarations)"
>
This is just if you want to add comments.
--Sean
next prev parent reply other threads:[~2022-01-27 16:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 0:24 [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Sean Anderson
2022-01-19 0:24 ` [PATCH v2 1/7] dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns Sean Anderson
2022-01-19 0:24 ` [PATCH v2 2/7] usb: dwc3: Get clocks individually Sean Anderson
2022-01-20 16:52 ` Robert Hancock
2022-01-19 0:24 ` [PATCH v2 3/7] usb: dwc3: Calculate REFCLKPER based on reference clock Sean Anderson
2022-01-20 16:53 ` Robert Hancock
2022-01-19 0:24 ` [PATCH v2 4/7] usb: dwc3: Program GFLADJ Sean Anderson
2022-01-20 16:55 ` Robert Hancock
2022-01-24 22:46 ` Thinh Nguyen
2022-01-24 23:06 ` Sean Anderson
2022-01-25 2:11 ` Thinh Nguyen
2022-01-25 6:17 ` Felipe Balbi
2022-01-25 20:02 ` Thinh Nguyen
2022-01-25 16:22 ` Sean Anderson
2022-01-25 19:36 ` Thinh Nguyen
2022-01-26 10:56 ` Felipe Balbi
2022-01-26 10:53 ` Felipe Balbi
2022-01-27 16:45 ` Sean Anderson [this message]
2022-01-19 0:24 ` [PATCH v2 5/7] usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI Sean Anderson
2022-01-24 22:44 ` Thinh Nguyen
2022-01-24 23:07 ` Sean Anderson
2022-01-24 23:14 ` Sean Anderson
2022-01-25 2:21 ` Thinh Nguyen
2022-01-19 0:24 ` [PATCH v2 6/7] arm64: dts: zynqmp: Move USB clocks to dwc3 node Sean Anderson
2022-01-20 16:56 ` Robert Hancock
2022-01-19 0:24 ` [PATCH v2 7/7] arm64: dts: ipq6018: Use reference clock to set dwc3 period Sean Anderson
2022-01-19 18:14 ` [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Baruch Siach
2022-01-19 18:23 ` Sean Anderson
2022-01-20 5:23 ` Kathiravan T
2022-01-20 10:29 ` Baruch Siach
2022-01-24 15:11 ` Kathiravan Thirumoorthy
2022-01-24 23:01 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756b3c4-02eb-8156-f973-bd592fa139ef@seco.com \
--to=sean.anderson@seco.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=baruch@tkos.co.il \
--cc=bjagadee@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.hancock@calian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).