From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161503AbcFGRQD (ORCPT ); Tue, 7 Jun 2016 13:16:03 -0400 Received: from ale.deltatee.com ([207.54.116.67]:43865 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbcFGRQA (ORCPT ); Tue, 7 Jun 2016 13:16:00 -0400 To: Jon Mason References: <20160604154035.GA11597@kudzu.us> Cc: Dave Jiang , Allen Hubbe , John Kading , Sudip Mukherjee , Arnd Bergmann , linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org From: Logan Gunthorpe Message-ID: <5757013F.2090401@deltatee.com> Date: Tue, 7 Jun 2016 11:15:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160604154035.GA11597@kudzu.us> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, arnd@arndb.de, sudipm.mukherjee@gmail.com, john.kading@gd-ms.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 2/3] ntb_transport: Check the number of spads the hardware supports X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jon, Thanks for the feedback. I'll send an updated patch in a moment. On 04/06/16 09:40 AM, Jon Mason wrote: > Nit, please add spaces around '*' (per checkpatch) I'll change this, but I did run it through checkpatch and it did not warn about this. > Please explicitly point out that this is being modified in the commit > message. I don't see them being used, so probably not a big deal > (unless Dave Jiang has something queued that will use it). Done. I feel like he can always add them back in when he adds the functionality. This way, when he does, MAX_SPAD will be updated and the check will still be correct. > Move this check above the dev_to_node assignment above. Done. Logan