linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: <wim@iguana.be>, <linux-kernel@vger.kernel.org>,
	<linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH] watchdog: max77620: Add support for watchdog timer
Date: Wed, 8 Jun 2016 14:28:57 +0530	[thread overview]
Message-ID: <5757DE51.6000201@nvidia.com> (raw)
In-Reply-To: <20160607175600.GA3712@roeck-us.net>

Hi Guenter,

Thanks for quick review. I will take care of most of comment.
I have one query fr following comment.

Thanks,
Laxman

On Tuesday 07 June 2016 11:26 PM, Guenter Roeck wrote:
> Hi,
>
> On Mon, Jun 06, 2016 at 05:22:44PM +0530, Laxman Dewangan wrote:
> +	/* Stop watchodog */
> +	ret = regmap_update_bits(wdt->rmap, MAX77620_REG_CNFGGLBL2,
> +				 MAX77620_WDTEN, 0);
> +	if (ret < 0) {
> +		dev_err(wdt->dev, "Failed to reset WDTEN: %d\n", ret);
> +		return ret;
> +	}
> Alternatively, you could set WDOG_HW_RUNNING to tell the watchdog core
> that the watchdog is already running. The watchdog core would then ping
> the watchdog until the watchdog device is opened.
>
> That would also require to tell the watchdog core about the current (or default)
> timeout, which doesn't seem to be set anywhere. That means it won't be set at all
> unless user space updates it explicitly. This is quite unusual. Is it on purpose
> or an oversight ? If it is on purpose, please explain.

OK, we have use cases where we have enabled the WDT in BL also. and keep 
runnign till kernel up.
Instead of stopping WDT, I can say that WDOG_HW_RUNING and current 
timeout can be read from the register.

Now, the WDT need to be ping periodically. Is there any flag which 
enabled the worker thread from core which will keep pinging till user 
space alive and activate the WDT?

  reply	other threads:[~2016-06-08  9:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 11:52 Laxman Dewangan
2016-06-07 17:56 ` Guenter Roeck
2016-06-08  8:58   ` Laxman Dewangan [this message]
2016-06-08 13:15     ` Guenter Roeck
2016-06-08 13:27       ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5757DE51.6000201@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    --subject='Re: [PATCH] watchdog: max77620: Add support for watchdog timer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).