From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426114AbcFHO2p (ORCPT ); Wed, 8 Jun 2016 10:28:45 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:41473 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423877AbcFHO2m (ORCPT ); Wed, 8 Jun 2016 10:28:42 -0400 Subject: Re: [PATCH v3 5/6] watchdog: pretimeout: add panic pretimeout governor To: Wolfram Sang References: <1465321127-19522-1-git-send-email-vladimir_zapolskiy@mentor.com> <1465321127-19522-6-git-send-email-vladimir_zapolskiy@mentor.com> <20160608070804.GD1521@katana> CC: Wim Van Sebroeck , Guenter Roeck , Robin Gong , , From: Vladimir Zapolskiy Message-ID: <57582B97.5040402@mentor.com> Date: Wed, 8 Jun 2016 17:28:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160608070804.GD1521@katana> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.76] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On 08.06.2016 10:08, Wolfram Sang wrote: > >> +static void pretimeout_panic(struct watchdog_device *wdd) >> +{ >> + panic("panic on watchdog pretimeout event\n"); >> +} > > And here we have the same redundant message again ("panic on") :( I will remove it then. > Did you look at my patches at all? To me, it looks like you didn't or > you are intentionally trying to leave my changes out. I don't think they > were all bad. No, they are not, and I'll include some of the changes to v4, if you don't mind. > In the previous patch in watchdog_notify_pretimeout() you used > the shortened message BTW. -- With best wishes, Vladimir