From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756392AbcFHOxN (ORCPT ); Wed, 8 Jun 2016 10:53:13 -0400 Received: from mail-db3on0104.outbound.protection.outlook.com ([157.55.234.104]:40391 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751560AbcFHOxJ (ORCPT ); Wed, 8 Jun 2016 10:53:09 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH] kernel/sysrq: reset watchdog on all CPUs while processing sysrq-w To: Ingo Molnar References: <1464353394-30528-1-git-send-email-aryabinin@virtuozzo.com> <20160608131324.GA15193@gmail.com> CC: Ingo Molnar , Peter Zijlstra , From: Andrey Ryabinin Message-ID: <57582E31.1040006@virtuozzo.com> Date: Wed, 8 Jun 2016 17:39:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160608131324.GA15193@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM2PR09CA0077.eurprd09.prod.outlook.com (10.160.228.173) To VI1PR0801MB1310.eurprd08.prod.outlook.com (10.167.197.148) X-MS-Office365-Filtering-Correlation-Id: dfa56751-5e8b-46d7-ed27-08d38faa9f5c X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;2:DQ2onS1GpY3eA8IX/KEiyyYc3vIkiwIZGlMxmihZlcgkZh0b1lYa8CIJSJdy85GtFaLhx8BIYTbz2VhvW0Ldd1kBgEWLKqyi7y5ABkIJv0wvq/MSn8dzFwZ4LFWGmPZr64FLjcY1cqrfBeqix/fIYDoxbYm6aBHkqvotbXrYAso+JgMiCKTmgAkSSEA3cfxO;3:Cg7PBXvmPDpYfD0A8xPuobZJXHKlXT5ZBtkCi3rYjWA+ZYKcUBwjScwFsdQHZLzc/J1MFBA3DsB/3ZKi0bHqnoNF296ClGbsWmhq9/tGhlkI06BaZy/prPpU7FhMAFgP X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1310; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;25:oW6kxZyJRNr07dDJP+VdsYfc7l16LPhhbQpNFPlti6az7Ubhkwtr8ItC/ZbDCog/b1OIEw8JRntoPhn7yZ7XrwT470B5bemZvLZMejICnfqHGEM5l2fAOZ9dMPUWeK9X8NNsm8KaH0wdi6rL6xdo/M/+ZDljq8tKKWnnYyZJZitqyRomExMt34D29GuQOCs0Vc+ijwpHJGgumL6sahXjZkNti6UdwolayRPHHiuPHSMtBsB+nbB4J/YJSB2a4t7fkjZ/objUYXo/PRrYdCvAmkpnT5FJCVMuPXGLboitcLHM8cPysK5Jo6rLSuyvgEVyh85ubWpKOP7pzz9KyppPDX8+96IGqNud/1+FjZqd52Luh+G6E+gZhJkVAx/8zb2XN3LLBY92XQ9cwy/75xbUyDudDs1EZUagCVovzf/hM897mBGgHJOTdmrz321YgJ4qVjpVZasY6OGujAqL+rBZ93xGpN01bsTTOP4+nYOYImg/g1HzjqbFttpr44JqIH1Gd+79eNejjvnXp5pSIx8MPb7NCrRe9OKtllznS+arEHv2rVX0oFZZq2CPC+0eKpua5UeJJiWgPmWBZjdixjlBV/sfFu6g7WmBul+1Tojt0UUzWx9oqvH7pHinp/yLbcbalehj6oCazj//rQ6h9Jq1Eu0JZSriDpyy+I13oK7/ItFMwHXlhLE9N9oxHaZgzzNoQyP07PG03K9ewq5vd7AmCg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046);SRVR:VI1PR0801MB1310;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1310; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;4:va32Y6PW3JpUrIkBw4CZ97TJTu4PH/w+BgOkO0zjy5OLyKtDuS9wY02tI+0UGcn6LdHfrhFzxaOcYR1HM9aieY7ULwigULU3g+BbgE7eN3AdNfUWXQzARX45um+6JfV4utDYh18aDk1IcEznuzAkQ3bIcZwuN82eQ8dciG901fJKkpsNV2pO+SL5tQaDoNvGvOVVfhJStw3H1u04L9EcFHDvBFHpIJYCk9DL5UrAykK6pySXXp8HkwLolBoINRfu85D50t/vk7m7p6S87Rvx2fvqaozuCjYmHhX4bm+ESdnbQ0tYyT89ym4cKg18l5BIjTXicRAd8yw+ErT/HeoT8FcfJW9iE9ChWzNAg18Sx5Nr7xyHeziJlkbcnv4lVQlT4Cb9BCnHUve2c3bzw0nMrgh4lOYVG5EP4bpJVZBuS6Q= X-Forefront-PRVS: 0967749BC1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(199003)(377454003)(189002)(24454002)(68736007)(230700001)(5008740100001)(33656002)(36756003)(23746002)(110136002)(5004730100002)(8676002)(59896002)(99136001)(87266999)(42186005)(80316001)(19580395003)(54356999)(65816999)(2906002)(19580405001)(101416001)(76176999)(50986999)(50466002)(105586002)(586003)(65956001)(6116002)(66066001)(92566002)(4326007)(3846002)(83506001)(77096005)(81166006)(97736004)(47776003)(4001350100001)(86362001)(81156014)(64126003)(106356001)(189998001)(65806001)(2950100001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB1310;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0801MB1310;23:3BPmcQ7DjehlKDooVul+JGEANA7qOj2z+eD?= =?Windows-1252?Q?5IjDNQBU4x+2Dm/D4lI6dkcgZ6Jjb5SDBHcLvwTVmLgqwjsezrPf9BGy?= =?Windows-1252?Q?rc91oAGdn4jLZRrGg0AXq2M7TN7JKoDS6wZSX9D4c4ajMxvQ2ZEGHuXu?= =?Windows-1252?Q?g45zg/EZhIbumBYC+VR8mNbxdnQsAA2nCk3wTgehU0nCWq0kiNh9sI6d?= =?Windows-1252?Q?vDuzLT49hOveTzAZ3Eppq2UmfeuFpisD0SGq2gy3WfhIt9+w4HqtWres?= =?Windows-1252?Q?jTGQnE8O13sMb3cyGaDZc9+gncJpuFnicZgX9dzlj55EerbFxC1ZKI3q?= =?Windows-1252?Q?llw7+I2PW8ZKIpcjTMvt4DrrFalxAfs6RwFDcwTabny9TRAIxa0ejgic?= =?Windows-1252?Q?BRM2uJCQqFebZ5s3cRy8vufhsqpMA+CaehoVFhm8ExOfXwb4WP2enDDP?= =?Windows-1252?Q?q6kVQRr1jy+rj9pCIwEjDBdjSbiEKPSKhaEh817UwhhSp39JxhQhc4pq?= =?Windows-1252?Q?jIqzudrrt8m6XAhNVQJ0Uj8Yu3PEdwcQwuufBUi8gmokmCTYrbqpD8jb?= =?Windows-1252?Q?NhY+Bf4UZ4eB0cLFHO/cHVkBNK0jsCYbmmlCaCphFQak55arRl7Wwq9r?= =?Windows-1252?Q?cHJg08cqGlLv1KUZHi9fKhw8r6Ay0oYzB8i+I3ljMn0F4RJYcpbxsVaK?= =?Windows-1252?Q?I5zWpQotw068YaBfWIEQ0qF/jqammqH3zDZbZ6jW2V/YsmRhYv29BVC1?= =?Windows-1252?Q?u5H5iASiUU4pAI7SmeLzjiOfaHu+Lg4ebDvuVbvS1rkje0K5YIneXXL+?= =?Windows-1252?Q?maHrnpizEuDmzmK7zDAQBX3dChBAVYzIw7MolLuWmy/y+7Jj+ZZW1qoV?= =?Windows-1252?Q?L4Uopuo7KnQmwfr8TAZZo/ooQJC0bY0MCLu1hZO4Pg7pfcVqCWoNE2+S?= =?Windows-1252?Q?W2hA2SsmMr0dfNiqzPO1CvAx3d9HnLcPz9ldohcWTbHEgs99+kG2xTPa?= =?Windows-1252?Q?0YMsY6G+9rSN/aRgPsXV9U76uGXUzBnKOkSA6iZAxpd0tHxCKI6t2Af+?= =?Windows-1252?Q?a8Ym3k/d6hFOySXfmzG/cJxnXu2XYqyPTfCPAv19JNFvX8Vtn0m/JQqh?= =?Windows-1252?Q?Vjh+luD306natFUc1tEfWgW9qxlXNPJbElPFumZ0ZooSa9G/rqoEBqG1?= =?Windows-1252?Q?4+32X+CwJ0v+nRegDQCilsvHq8kRTS4pD5tDu9dNi6+3vlvAxe9TDXvn?= =?Windows-1252?Q?BRnwg9NF16mQYhtx0aRZFbQ64d4x+yiZF+OEAdR5c9gBhpIj6Tj+cIiy?= =?Windows-1252?Q?PchY2PFMs74EvrwoMHZRGCpLGoChc4rYj1p8BVNOOAF6jxi0nXCLSMJW?= =?Windows-1252?Q?OQZ3d7TTk2OFtZJNLk6uml2t4N7L27uQjHA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;5:/2fiIOb8RiKN29BJtFTwO9QfBJ59WmvWDVrJ1P06Q4bf+k2ZWF+vV9R8rDZ+V7GkXiD4Ctbmc81J6Yc12gg/qMnqiV3wH6PNeWiNGji0ngRPHqPREaI/AA1rFS7uvBu8Ai02n1eqLm4ctQAtlcAZbA==;24:35StiOX3dblsRk1NIgKYzpAb40l3k64YsKqU1H9j4P8Vg+A6iD0xGFBDKcPg00RhOg3nOkr0nVg7ruS8vkE0scJGHVtc9htM/CMWton1B1E=;7:amz6E06+C4bIRkaSyQ081JugzMle21qmcisGKqFGD9KMT+ggQzMRXwBQmdhHq9O1eAw14Jk5oDFcuKAIAzzdGyD6hz0H71LW0Zy1TdIv9nmrxbQflNucSRqh8vctk9r/zQqKmAAuua9SyzSbQEVFYbkud0sp0n5G8qjEb+gCM9qiCA9bXJsRCNWRp8SPHeuIJm5NIHz4RzB8OKXLQ8GSH6W62h10Aa5e88dtAX1YLj8=;20:KCFQ+BZdGaP55dNqfubwi9h8BDFYarC3cGrumllVIwUnH3iE8YqmmrTqjXshA8DpcaqTuQPfOTmTWSaeZWHFy2aWv/9dOyX6gUlNsmfWudVMQYbMbw/+r5H4MWmm2XgBgjnLDc79vYcloG0eTC9lNJWPEtvgLiEOZFAU/aj50qU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2016 14:38:56.5876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1310 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2016 04:13 PM, Ingo Molnar wrote: > > * Andrey Ryabinin wrote: > >> Lengthy output of sysrq-w may take a lot of time on slow serial console. >> Currently we reset NMI-watchdog on the current CPU to avoid softlockup. >> Sometimes this doesn't work since watchdog might trigger on the other >> CPU which is waiting for an IPI to proceed. >> >> Reset watchdog on all CPUs to prevent spurious softlockup messages. >> >> Signed-off-by: Andrey Ryabinin >> --- >> kernel/sched/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index 7f2cae4..c135eee 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -5134,7 +5134,7 @@ void show_state_filter(unsigned long state_filter) >> * reset the NMI-timeout, listing all files on a slow >> * console might take a lot of time: >> */ >> - touch_nmi_watchdog(); >> + touch_all_softlockup_watchdogs(); > > So don't we want both? > Indeed, we need both. I was under the false impression that touch_all_softlockup_watchdogs() will reset NMI timeout too > Thanks, > > Ingo >