From: Ben Greear <greearb@candelatech.com>
To: Prasun Maiti <prasunmaiti87@gmail.com>,
"Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: Linux Next <linux-next@vger.kernel.org>,
"ath6kl@lists.infradead.org" <ath6kl@lists.infradead.org>,
Linux Wireless <linux-wireless@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns
Date: Wed, 8 Jun 2016 08:51:24 -0700 [thread overview]
Message-ID: <57583EFC.3070901@candelatech.com> (raw)
In-Reply-To: <CAEO8o4=XEr4DQC3bqAXGE01s5WC+kuZ3PqoJFtuSCE52RNyDzA@mail.gmail.com>
On 06/08/2016 08:46 AM, Prasun Maiti wrote:
> Please tell me if I mention that this code is untested in commit log,
> then could you check the code kindly and also help me to fix this type
> of warning?
In my experience, ath6kl has very fragile and buggy firmware, so I would
not add any new API to it unless you have tested this thoroughly.
Thanks,
Ben
>
> On Wed, Jun 8, 2016 at 9:00 PM, Valo, Kalle <kvalo@qca.qualcomm.com> wrote:
>> Prasun Maiti <prasunmaiti87@gmail.com> writes:
>>
>>> I am not sure it works fine. Like ath6kl driver send another cmd to
>>> firmare, I have just filled up the cmd buffer with "tx_ant", and
>>> "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd
>>> buffer to firmware. I have resend the patch as there are some errors
>>> in the previous patch. Let me know if any modifications are needed?
>>
>> I don't take untested code. In some special cases it might be ok to send
>> untested code but even then it needs to be clearly stated in the commit
>> log that it's untested.
>>
>> Please resend once you have tested this, I'm dropping this now.
>>
>> --
>> Kalle Valo
>
>
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2016-06-08 15:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 12:21 [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns Prasun Maiti
2016-06-08 14:21 ` kbuild test robot
2016-06-08 14:23 ` Valo, Kalle
2016-06-08 14:35 ` Prasun Maiti
2016-06-08 14:46 ` Valo, Kalle
2016-06-08 15:20 ` Prasun Maiti
2016-06-08 15:30 ` Valo, Kalle
2016-06-08 15:46 ` Prasun Maiti
2016-06-08 15:51 ` Ben Greear [this message]
2016-06-08 15:56 ` Prasun Maiti
2016-06-08 16:10 ` Ben Greear
2016-06-09 0:05 ` Julian Calaby
2016-06-09 5:04 ` Prasun Maiti
2016-06-09 5:36 ` [PATCH] Add .set_antenna callback in ath6kl driver to fix " Prasun Maiti
2016-06-09 6:43 ` Johannes Berg
2016-06-09 7:08 ` Valo, Kalle
2016-06-08 15:09 ` Prasun Maiti
2016-06-11 20:33 ` [PATCH] Add .set_antenna callback in ath6kl driver to remove " kbuild test robot
2016-06-11 20:35 ` kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2016-06-08 10:51 Prasun Maiti
2016-06-08 12:19 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57583EFC.3070901@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath6kl@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prasunmaiti87@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).