From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1424464AbcFIH0B (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Jun 2016 03:26:01 -0400
Received: from devils.ext.ti.com ([198.47.26.153]:34176 "EHLO
	devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1423277AbcFIHZ7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Jun 2016 03:25:59 -0400
Subject: Re: [PATCH v9 11/14] usb: otg: use dev_dbg() instead of VDBG()
To: Joe Perches <joe@perches.com>, <peter.chen@freescale.com>
References: <1465376626-30122-1-git-send-email-rogerq@ti.com>
 <1465376626-30122-12-git-send-email-rogerq@ti.com>
 <1465398640.25087.50.camel@perches.com>
CC: <balbi@kernel.org>, <tony@atomide.com>, <gregkh@linuxfoundation.org>,
        <dan.j.williams@intel.com>, <mathias.nyman@linux.intel.com>,
        <Joao.Pinto@synopsys.com>, <sergei.shtylyov@cogentembedded.com>,
        <jun.li@freescale.com>, <grygorii.strashko@ti.com>,
        <yoshihiro.shimoda.uh@renesas.com>, <robh@kernel.org>,
        <nsekhar@ti.com>, <b-liu@ti.com>, <linux-usb@vger.kernel.org>,
        <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
From: Roger Quadros <rogerq@ti.com>
Message-ID: <575919F3.7020807@ti.com>
Date: Thu, 9 Jun 2016 10:25:39 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1465398640.25087.50.camel@perches.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/06/16 18:10, Joe Perches wrote:
> On Wed, 2016-06-08 at 12:03 +0300, Roger Quadros wrote:
>> Now that we have a device reference in struct usb_otg
>> let's use dev_dbg() for debug messages.
> 
> dev_vdbg vs dev_dbg
> 
> The patch subject and commit message don't match the code changes.

Indeed. Will fix it. Thanks.

> 
>> diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c
> []
>> @@ -44,8 +37,9 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol)
>>  	int ret = 0;
>>  
>>  	if (fsm->protocol != protocol) {
>> -		VDBG("Changing role fsm->protocol= %d; new protocol= %d\n",
>> -			fsm->protocol, protocol);
>> +		dev_vdbg(otg->dev,
>> +			 "Changing role fsm->protocol= %d; new protocol= %d\n",
>> +			 fsm->protocol, protocol);
> 
> etc...
> 

--
cheers,
-roger