From: Wadim Egorov <w.egorov@phytec.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
rtc-linux@googlegroups.com, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
mturquette@baylibre.com, sboyd@codeaurora.org,
lgirdwood@gmail.com, broonie@kernel.org, a.zummo@towertech.it,
alexandre.belloni@free-electrons.com, dianders@chromium.org,
zyw@rock-chips.com
Subject: Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support
Date: Thu, 9 Jun 2016 15:11:56 +0200 [thread overview]
Message-ID: <57596B1C.2010101@phytec.de> (raw)
In-Reply-To: <20160609111201.GA1388@dell>
On 09.06.2016 13:12, Lee Jones wrote:
> On Thu, 09 Jun 2016, Wadim Egorov wrote:
>> On 08.06.2016 16:17, Lee Jones wrote:
>>> On Thu, 02 Jun 2016, Wadim Egorov wrote:
>>>
>>>> The RK818 chip is a power management IC for multimedia and handheld
>>> "Power Management IC (PMIC)"
>>>
>>>> devices. It contains the following components:
>>>>
>>>> - Regulators
>>>> - RTC
>>>> - Clkout
>>> Clocking
>>>
>>>> - battery support
>>> Battery support
>>>
>>>> Both chips RK808 and RK818 are using a similar register map.
>>> "Both RK808 ad RK818 chips"
>>>
>>>> So we can reuse the RTC and Clkout functionality.
>>> Swap '.' for ','.
>>>
>>>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
>>>> ---
>>>> drivers/mfd/Kconfig | 4 +-
>>>> drivers/mfd/rk808.c | 231 ++++++++++++++++++++++++++++++++++++++--------
>>>> include/linux/mfd/rk808.h | 162 ++++++++++++++++++++++++++++++--
>>>> 3 files changed, 350 insertions(+), 47 deletions(-)
> [...]
>
>>>> -struct rk808_reg_data {
>>>> - int addr;
>>>> - int mask;
>>>> - int value;
>>>> -};
>>> Why are you moving this to the header?
>> It is now part of the rk808 struct.
> Why?
>
For me it seemed reasonable. My idea was to have only one chip variant
check.
I can move the rk808_reg_data struct back to the c file, check for the
chip variant within the probe function and initialize the proper
reg_data variable.
This would also apply to the mfd_cell variables.
next prev parent reply other threads:[~2016-06-09 13:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 6:50 [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Wadim Egorov
2016-06-02 6:50 ` [RESEND PATCH v5 2/5] regulator: rk808: Add regulator driver for RK818 Wadim Egorov
2016-06-02 6:50 ` [RESEND PATCH v5 3/5] mfd: dt-bindings: Add RK818 device tree bindings document Wadim Egorov
2016-06-08 14:23 ` Lee Jones
2016-06-02 6:50 ` [RESEND PATCH v5 4/5] clk: Kconfig: Name RK818 in Kconfig for COMMON_CLK_RK808 Wadim Egorov
2016-07-06 22:22 ` Michael Turquette
2016-06-02 6:50 ` [RESEND PATCH v5 5/5] rtc: Kconfig: Name RK818 in Kconfig for RTC_DRV_RK808 Wadim Egorov
2016-06-08 14:17 ` [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Lee Jones
2016-06-09 8:23 ` Wadim Egorov
2016-06-09 11:12 ` Lee Jones
2016-06-09 13:11 ` Wadim Egorov [this message]
2016-06-09 15:28 ` Lee Jones
2016-07-06 3:15 ` Andy Yan
2016-07-06 8:03 ` Wadim Egorov
2016-07-06 8:56 ` Andy Yan
2016-08-05 12:22 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57596B1C.2010101@phytec.de \
--to=w.egorov@phytec.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sboyd@codeaurora.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).