From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbcFJBvp (ORCPT ); Thu, 9 Jun 2016 21:51:45 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:39102 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbcFJBvn (ORCPT ); Thu, 9 Jun 2016 21:51:43 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee691-f79196d000001483-1c-575a1d2cf4bb Content-transfer-encoding: 8BIT Message-id: <575A1D2C.5060101@samsung.com> Date: Fri, 10 Jun 2016 10:51:40 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Sebastian Reichel Cc: dbaryshkov@gmail.com, dwmw2@infradead.org, wens@csie.org, myungjoo.ham@samsung.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] power: axp288_charger: Replace deprecatd API of extcon References: <1464687280-8155-1-git-send-email-cw00.choi@samsung.com> <1464687280-8155-2-git-send-email-cw00.choi@samsung.com> <20160610014643.GC5848@earth> In-reply-to: <20160610014643.GC5848@earth> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkSFdXNirc4EQzk8WkJ++ZLSaunMxs cXnXHDaLz71HGC1uN65gszi9u8Ti56HzTA7sHhserWb12DnrLrvH5hVaHptWdbJ59G1Zxejx eZNcAFsUl01Kak5mWWqRvl0CV8ajjiaWgma+inMzl7A2MJ7h7mLk5JAQMJHoPPKcHcIWk7hw bz1bFyMXh5DACkaJC4s/MMMUXdvxACqxlFFi5tfdTCAJXgFBiR+T77F0MXJwMAvISxy5lA0S ZhZQl5g0bxEzRP0DRomefX/ZIeq1JP48fcEKYrMIqEo0dB9lAbHZgOL7X9xgA5kjKhAh0X2i EiQsIqAm8f7SUxaQOcwCkxglDn1eANYrLBAi8XnvTagFnxkltn2ZDnYpJ9Cgl3tusoIkJARu sUtc2/OPEWKbgMS3yYfALpUQkJXYdADqM0mJgytusExgFJuF5J9ZCP/MQvLPAkbmVYyiqQXJ BcVJ6UWmesWJucWleel6yfm5mxiB0Xf637OJOxjvH7A+xCjAwajEw2vxMjJciDWxrLgy9xCj KdARE5mlRJPzgTGeVxJvaGxmZGFqYmpsZG5ppiTOqyP9M1hIID2xJDU7NbUgtSi+qDQntfgQ IxMHp1QDo9vEV8zV7vz2ymof07kFBYUze+6tt+h4VPDrRoZ16Km+lymrf+xNCgn19zm28+yO Vyb/YiOZ2B//79tstOND603troyZW34tctrVt36leav/vwNRD4I1lok2RuZu27Snp+K7qL80 480NHVXv2e94BhaxtM/e/nkJx+87daXe81ct2ZW659KK00osxRmJhlrMRcWJAPgMdAO5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t9jAV0d2ahwg90vFC0mPXnPbDFx5WRm i8u75rBZfO49wmhxu3EFm8Xp3SUWPw+dZ3Jg99jwaDWrx85Zd9k9Nq/Q8ti0qpPNo2/LKkaP z5vkAtiiGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0y c4BOUVIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBmPOpoYilo5qs4N3MJ awPjGe4uRk4OCQETiWs7HrBB2GISF+6tB7K5OIQEljJKzPy6mwkkwSsgKPFj8j2WLkYODmYB eYkjl7JBwswC6hKT5i1ihqh/wCjRs+8vO0S9lsSfpy9YQWwWAVWJhu6jLCA2G1B8/4sbbCBz RAUiJLpPVIKERQTUJN5fesoCModZYBKjxKHPC8B6hQVCJD7vvQm14DOjxLYv05lBEpxAg17u uck6gVFgFpL7ZiHcNwvJfQsYmVcxSqQWJBcUJ6XnGuWllusVJ+YWl+al6yXn525iBEf4M+kd jId3uR9iFOBgVOLhTeCJChdiTSwrrsw9xCjBwawkwlsjARTiTUmsrEotyo8vKs1JLT7EaAr0 4ERmKdHkfGDyySuJNzQ2MTOyNDI3tDAyNlcS5338f12YkEB6YklqdmpqQWoRTB8TB6dUA6PP pZ4TDx1nB04951s3Z1rEgzOri/frRkiVHQ+t2qIrueBg7eFLpvPS9Co37t13miGvf/G9qkMy qW+DO5fuONaeedR14pZV/KYGsg2PNx6d/qjaICU/w/eH2O9gkzm167pFzx2VrtNyrZW5fGZt 6yL5xJ6w/SzbM1OKXCssVPa/f6unskbePESJpTgj0VCLuag4EQDlWV70BgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2016년 06월 10일 10:46, Sebastian Reichel wrote: > Hi, > > On Tue, May 31, 2016 at 06:34:39PM +0900, Chanwoo Choi wrote: >> This patch removes the deprecated notifier API of extcon framework and then use >> the new extcon API[2] with the unique id[1] to indicate the each external >> connector. Alter deprecated API as following: >> - extcon_register_interest() -> extcon_register_notifier() >> - extcon_unregister_interest() -> extcon_unregister_notifier() >> - extcon_get_cable_state() -> extcon_get_cable_state_() >> >> And, extcon alters the name of USB charger connector in patch[3] as following: >> - EXTCON_CHG_USB_SDP /* Standard Downstream Port */ >> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ >> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ >> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */ >> >> [1] Commit 2a9de9c0f08d61 >> - ("extcon: Use the unique id for external connector instead of string) >> [2] Commit 046050f6e623e4 >> - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon >> [3] Commit 11eecf910bd81d >> - ("extcon: Modify the id and name of external connector") >> >> Signed-off-by: Chanwoo Choi >> --- >> drivers/power/axp288_charger.c | 77 +++++++++++++++++++++++++++++------------- >> 1 file changed, 53 insertions(+), 24 deletions(-) > > Acked-By: Sebastian Reichel > To prevent the build error on linux-next, this patchset should be merged on one repository. So, I think that there are two solution. First, I'll make the immutable branch for them and send pull request to you. Second, I'll apply this patchset on extcon git repository. Which would you prefer? If you answer, I'll do right now. Thanks, Chanwoo Choi