From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742AbcFJGNf (ORCPT ); Fri, 10 Jun 2016 02:13:35 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:60248 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbcFJGNd (ORCPT ); Fri, 10 Jun 2016 02:13:33 -0400 X-AuditID: cbfec7f5-f792a6d000001302-67-575a5a8a33cf Subject: Re: [PATCH 1/2] max8903: adds support for initiation via device tree. To: chris@lapa.com.au References: <1464849897-21527-1-git-send-email-chris@lapa.com.au> <1464849897-21527-2-git-send-email-chris@lapa.com.au> <98c757cd-d1b4-1599-ebb3-2a9cc3fc478d@lapa.com.au> Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <575A5A88.3070404@samsung.com> Date: Fri, 10 Jun 2016 08:13:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <98c757cd-d1b4-1599-ebb3-2a9cc3fc478d@lapa.com.au> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLLMWRmVeSWpSXmKPExsVy+t/xq7pdUVHhBi9vcFo8PGNm8fqFocXl XXPYLD73HmF0YPFYNnczo0ffllWMHp83yQUwR3HZpKTmZJalFunbJXBlnFm8iqWggaXi+2qB BsZJzF2MnBwSAiYSf1q7GCFsMYkL99azdTFycQgJLGWU6FvYCFYkJPCMUWLi/PAuRg4OYQE/ iY9TwepFBEQlfv7dzA5R/5VR4uri7awgCWYBK4ldj/rAitgEjCU2L1/CBmLzCmhJ7Lr4DqyG RUBV4u3lTWC2qECExKztP5ggagQlfky+xwJicwrYSxy6vJwVZC+zgLrElCm5EOPlJTavecs8 gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rpFecmFtcmpeul5yfu4kREqhfdzAuPWZ1iFGA g1GJhzdiV2S4EGtiWXFl7iFGCQ5mJRFescCocCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8M3e9 DxESSE8sSc1OTS1ILYLJMnFwSjUwLqvbp2T8vDrh3n3uP3WOPPyuv/0+rPI1usc2temP6If2 OvEF3OWcW7lPXrhR8nKiiFnFf5tDTs+yWfvdelwWHrY8fm3lFeZ9dqbzDvDN/PKqNL3M7Yth aSx/693C5fvVRMVLmNcyWs5QfB/VuHt+3ynphbu8iu9U8Z5KLnszzevzlnfpXz7fU2Ipzkg0 1GIuKk4EAOM/nO9QAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2016 07:35 AM, Chris Lapa wrote: > Hi Krzysztof, > > Thanks for the review. I'm working on those changes now. > > However just so I know for the future. Why no error checking on > devm_kzalloc() result? Looking through the source for devm_kzalloc() it > looks like NULL isn't caught anywhere else. Error checking is necessary. Just do not print the error message. The kernel core will print one with full back trace. if (charger == NULL) return -ENOMEM; Best regards, Krzysztof