From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932436AbcFJJwp (ORCPT ); Fri, 10 Jun 2016 05:52:45 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:45177 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbcFJJwn (ORCPT ); Fri, 10 Jun 2016 05:52:43 -0400 Subject: Re: [PATCH] usb: dwc3: fix runtime PM in error path To: Felipe Balbi , References: <1465548878-30085-1-git-send-email-rogerq@ti.com> <87eg85769o.fsf@linux.intel.com> CC: , From: Roger Quadros Message-ID: <575A8DE2.70505@ti.com> Date: Fri, 10 Jun 2016 12:52:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <87eg85769o.fsf@linux.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SUtSeIGq4gKflBDL3hHkOqhWQrbRC6qSW" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --SUtSeIGq4gKflBDL3hHkOqhWQrbRC6qSW Content-Type: multipart/mixed; boundary="wO1HBr0CR2xXHCrVfhnDvVRJbhi0xEGvQ" From: Roger Quadros To: Felipe Balbi , grygorii.strashko@ti.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <575A8DE2.70505@ti.com> Subject: Re: [PATCH] usb: dwc3: fix runtime PM in error path References: <1465548878-30085-1-git-send-email-rogerq@ti.com> <87eg85769o.fsf@linux.intel.com> In-Reply-To: <87eg85769o.fsf@linux.intel.com> --wO1HBr0CR2xXHCrVfhnDvVRJbhi0xEGvQ Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/06/16 12:16, Felipe Balbi wrote: >=20 > Hi, >=20 > Roger Quadros writes: >> If there is a failure after pm_runtime_enable/get_sync() >> we need to call pm_runtime_disable/put_sync(). >> >> Otherwise it will lead to an unbalanced pm_runtime_enable() on the >> subsequent probe if the earlier probe bailed out due to -EPROBE_DEFER.= >> >> Signed-off-by: Roger Quadros >=20 > where is this supposed to be applied? You're not checking if On your testing/next > pm_runtime_get() failed at all. >=20 I'm not adding pm_runtime_get in my patch. Just fixing up the failure path in core.c. cheers, -roger --wO1HBr0CR2xXHCrVfhnDvVRJbhi0xEGvQ-- --SUtSeIGq4gKflBDL3hHkOqhWQrbRC6qSW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXWo3jAAoJENJaa9O+djCTJ5YP/Rd3qIMDg2dRP4+ykuotTW6Z PgZHkJp8hN07YfJ24+Ibti4u8Q9tO6TvdaIATYmeX9NvvMUiBxecI/XrRQ9oTxiF kD/2lEylUXfTGc4w3GXhlob44YJjY5PwOwW4x32svQVG33M9PQXolxGF0HgmTnFM l90eliuJ2hj0w/b27IeuzaX7HJRoz7K8Y/6J03yuMv8Wlmdw7bGshJWs3pAMQ+HI WI3rPMi6GeSnk3Eb343BKeG0YoBB7zFEzM46Tk8aV3gUC+n6rIgvQ8yA3MlVOntf CmzpGU4BZN9yy2LEanTXpxXqqybrDVb18le6HSv4OGZb3K05w63tgNUAUUwYbfjJ 6BIFxsU/ewaQxTveZgjNLeQ0UCgC2Z8p37IbET9HEM416C4lH4MJs1FwDXcOU1a/ F0gcVKnHvAmnK7lh31dOcIJ4XqKRXt/UaAE5K0dipyLkMKxZA/FwpCQqNuAeq9te qWcmDkFNOTxHCVw76VRzMbYEZX5LiW4vfKtl/owoZeYHjSqai9E03jxvnmEBy6dZ g/6FQhtFzIjFRPqPPfSgwB98c6dWdfluhxQMxJT0V1cfPXcI+Xml0xKtrRF3LBJk Vg9A8NH5Wir2In6njv0ov6KPxtaE0SQRjGmdCLxICXlHn44RKRUCeEUHsEHj3zYE 1OinJtUhDRoZR1n6dpyx =VgV6 -----END PGP SIGNATURE----- --SUtSeIGq4gKflBDL3hHkOqhWQrbRC6qSW--