From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbcFJLrt (ORCPT ); Fri, 10 Jun 2016 07:47:49 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:20965 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741AbcFJLrr (ORCPT ); Fri, 10 Jun 2016 07:47:47 -0400 X-AuditID: cbfec7f5-f792a6d000001302-07-575aa8e097f5 Subject: Re: [RFC PATCH 05/15] tty: serial: samsung: fixup accessors for endian To: Ben Dooks , Matthew Leach References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-6-matthew@mattleach.net> <71328b3d-dc2f-3eb9-b664-4d621db23131@codethink.co.uk> Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org From: Krzysztof Kozlowski Message-id: <575AA8DF.9020701@samsung.com> Date: Fri, 10 Jun 2016 13:47:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <71328b3d-dc2f-3eb9-b664-4d621db23131@codethink.co.uk> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t/xK7oPVkSFG5yer2Xx4FYrk0Xz4vVs FlM2fGCyeP3C0GLT42usFpd3zWGzmHF+H5PFmcW97BaNS5exOHB6PHs5mclj/9w17B6bl9R7 TP2wjsWjb8sqRo/1W66yeHzeJBfAHsVlk5Kak1mWWqRvl8CV8bxlJVPBV+6K7b/mMzUw9nN1 MXJySAiYSKzf/YIdwhaTuHBvPVsXIxeHkMBSRonpT56zQDjPGCWOfXzBBlIlLOAvsfTfGiYQ W0QgQGJj+zlmiKIljBIN0/rAHGaBW4wSO5/uAqtiEzCW2Lx8CVg3r4CWxL2ZTawgNouAqsSk j0sYQWxRgQiJWdt/MEHUCEr8mHyPBcTmFHCWuL2pH6iGA2ionsT9i1ogYWYBeYnNa94yT2AU mIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGukVJ+YWl+al6yXn525ihMTC1x2MS49ZHWIU4GBU 4uGN2BUZLsSaWFZcmXuIUYKDWUmEd+3SqHAh3pTEyqrUovz4otKc1OJDjNIcLErivDN3vQ8R EkhPLEnNTk0tSC2CyTJxcEo1MCqLxT5qKumuNGe6zDF327feugbteSvvM/BZONwUC75qI7PJ Y8Ib9uc/Ju62P5F2OuPnVZHlbrE8fr8swxcf6zq5oOvuFdO7O7Mvfzp1/nHh3UeLltypdF+V ExS650XrWWNu/lipDw8az0ovrzJTMMvZ5P+5v/bd3H2brhfp9Lg0ZXO52S9teKLEUpyRaKjF XFScCABQv2ImgQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2016 12:13 PM, Ben Dooks wrote: > On 08/06/16 19:31, Matthew Leach wrote: >> Fix the serial access code to deal with kernels built for big endian >> operation. >> >> Signed-off-by: Matthew Leach >> --- >> CC: Greg Kroah-Hartman >> CC: Jiri Slaby >> CC: linux-serial@vger.kernel.org >> CC: linux-kernel@vger.kernel.org >> --- >> drivers/tty/serial/samsung.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h >> index fc5deaa..8818bdd 100644 >> --- a/drivers/tty/serial/samsung.h >> +++ b/drivers/tty/serial/samsung.h >> @@ -118,9 +118,9 @@ struct s3c24xx_uart_port { >> ((unsigned long *)(unsigned long)((port)->membase + (reg))) >> >> #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg))) >> -#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg))) >> +#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) > > For completeness we should have changed __raw_readb to readb_relaxed > >> #define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg)) >> -#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg)) >> +#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) > > Acked-by: Ben Dooks With the readb_relaced change: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof