From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933036AbcFJPrN (ORCPT ); Fri, 10 Jun 2016 11:47:13 -0400 Received: from www.sr71.net ([198.145.64.142]:39993 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932910AbcFJPrH (ORCPT ); Fri, 10 Jun 2016 11:47:07 -0400 Subject: Re: [tip:perf/core] perf/x86/rapl: Add Skylake server model detection To: Jacob Pan , Vince Weaver References: <20160603001953.38848836@viggo.jf.intel.com> <20160610053547.731ea62d@yairi> Cc: hpa@zytor.com, dave.hansen@linux.intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, jolsa@redhat.com, eranian@google.com, tglx@linutronix.de, luto@amacapital.net, brgerst@gmail.com, alexander.shishkin@linux.intel.com, bp@alien8.de, torvalds@linux-foundation.org, dvlasenk@redhat.com, linux-tip-commits@vger.kernel.org From: Dave Hansen Message-ID: <575AE0F1.5020201@sr71.net> Date: Fri, 10 Jun 2016 08:46:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160610053547.731ea62d@yairi> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2016 05:35 AM, Jacob Pan wrote: >> > code does not match git commit message. The code says that skylake >> > server matches the haswell server. (Yes I know broadwell server >> > apparently matches haswell server too, but you might want to say that >> > in the git commit to avoid confusion). >> > > Yes, it would be more clear to state that SKX matches BDX as well as > HSX. I was following the order of product releases. Should I submit a > patch for it? or can the commit message be changed by the maintainers? Once it's been committed to git, maintainers can't change the commit message without rebasing. I wouldn't worry about it.