From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932813AbcFJSQg (ORCPT ); Fri, 10 Jun 2016 14:16:36 -0400 Received: from ale.deltatee.com ([207.54.116.67]:54731 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751928AbcFJSQf (ORCPT ); Fri, 10 Jun 2016 14:16:35 -0400 To: Kees Cook References: <573DF82D.50006@deltatee.com> <20160520071517.GB14191@gmail.com> <7b865a03-484f-2d10-aa3e-d9c0d04caecb@tycho.nsa.gov> <573FC081.20006@deltatee.com> <575A3E95.5090100@deltatee.com> Cc: "Rafael J. Wysocki" , Stephen Smalley , Ingo Molnar , Ingo Molnar , the arch/x86 maintainers , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Andy Lutomirski , Borislav Petkov , Denys Vlasenko , Brian Gerst From: Logan Gunthorpe Message-ID: <575B03F1.3060206@deltatee.com> Date: Fri, 10 Jun 2016 12:16:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: brgerst@gmail.com, dvlasenk@redhat.com, bp@alien8.de, luto@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, x86@kernel.org, mingo@redhat.com, mingo@kernel.org, sds@tycho.nsa.gov, rafael@kernel.org, keescook@chromium.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: PROBLEM: Resume form hibernate broken by setting NX on gap X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, On 10/06/16 12:09 PM, Kees Cook wrote: >> restore_code: ffff880157c3b000 >> jump_addr: ffffffff81446be0 >> >> >> diff --git a/arch/x86/power/hibernate_64.c b/arch/x86/power/hibernate_64.c >> index 009947d..6efedb7 100644 >> --- a/arch/x86/power/hibernate_64.c >> +++ b/arch/x86/power/hibernate_64.c >> @@ -92,6 +92,9 @@ int swsusp_arch_resume(void) >> memcpy(relocated_restore_code, &core_restore_code, >> &restore_registers - &core_restore_code); >> >> + pr_info("restore_code: %p\n", relocated_restore_code); >> + pr_info("jump_addr: %lx\n", restore_jump_address); >> + > > Also interesting would be the "relocated_restore_code" address, as > well as a dump of /sys/kernel/debug/kernel_page_tables (from > CONFIG_X86_PTDUMP). Is that not what I printed? If not, can you give me a better hint as to what you're looking for so I can spin another kernel? I'll also provide the kernel_page_tables once I do that. > I'm baffled by the problem, but the best I can understand is the the > relocated_restore_code range isn't executable (which should be visible > from finding it in /sys/kernel/debug/kernel_page_tables), but I don't > see how to solve that since my original patch didn't work. Yeah this is definitely a baffling problem. Thanks, Logan