From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: David Miller <davem@davemloft.net>
Cc: mugunthanvnm@ti.com, linux-kernel@vger.kernel.org,
grygorii.strashko@ti.com, linux-omap@vger.kernel.org,
netdev@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, bcousson@baylibre.com, tony@atomide.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] net: ethernet: ti: cpsw: remove rx_descs property
Date: Sat, 11 Jun 2016 13:11:29 +0300 [thread overview]
Message-ID: <575BE3D1.5000507@linaro.org> (raw)
In-Reply-To: <20160610.225043.1035032413161700163.davem@davemloft.net>
On 11.06.16 08:50, David Miller wrote:
> From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Date: Tue, 7 Jun 2016 16:59:35 +0300
>
>> if (!cpsw_common_res_usage_state(priv)) {
>> + int buf_num;
>> struct cpsw_priv *priv_sl0 = cpsw_get_slave_priv(priv, 0);
>>
>
> Please always order local variable declarations from longest to shortest
> line.
>
I will correct it in v3
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2016-06-11 10:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 13:59 [PATCH v2 0/2] net: ethernet: ti: cpsw: delete rx_descs property Ivan Khoronzhuk
2016-06-07 13:59 ` [PATCH v2 1/2] net: ethernet: ti: cpsw: remove " Ivan Khoronzhuk
2016-06-11 5:50 ` David Miller
2016-06-11 10:11 ` Ivan Khoronzhuk [this message]
2016-06-07 13:59 ` [PATCH v2 2/2] Documentation: DT: " Ivan Khoronzhuk
2016-06-08 20:11 ` Rob Herring
2016-06-07 15:26 ` [PATCH v2 0/2] net: ethernet: ti: cpsw: delete " Schuyler Patton
2016-06-08 14:01 ` Ivan Khoronzhuk
2016-06-08 14:06 ` Ivan Khoronzhuk
2016-06-08 23:11 ` Schuyler Patton
2016-06-09 0:03 ` Ivan Khoronzhuk
2016-06-10 23:04 ` Schuyler Patton
2016-06-13 8:22 ` Mugunthan V N
2016-06-13 15:19 ` Andrew F. Davis
2016-06-14 12:38 ` Ivan Khoronzhuk
2016-06-14 14:16 ` Mugunthan V N
2016-06-14 12:26 ` Ivan Khoronzhuk
2016-06-14 12:25 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575BE3D1.5000507@linaro.org \
--to=ivan.khoronzhuk@linaro.org \
--cc=bcousson@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).