From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbcFKPa4 (ORCPT ); Sat, 11 Jun 2016 11:30:56 -0400 Received: from ale.deltatee.com ([207.54.116.67]:57720 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbcFKPay (ORCPT ); Sat, 11 Jun 2016 11:30:54 -0400 To: Allen Hubbe References: Cc: Jon Mason , Dave Jiang , Shuah Khan , Sudip Mukherjee , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, linux-kselftest@vger.kernel.org From: Logan Gunthorpe Message-ID: <575C2EA6.9060208@deltatee.com> Date: Sat, 11 Jun 2016 09:30:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 50.66.97.235 X-SA-Exim-Rcpt-To: linux-kselftest@vger.kernel.org, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, shuahkh@osg.samsung.com, dave.jiang@intel.com, jdmason@kudzu.us, allenbh@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 7/8] ntb_pingpong: Add a debugfs file to get the ping count X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The pp_debugfs_dir is already initialized by the module init function. > If it doesn't exist here, I think we should just return instead of > trying again. It's also worth noting, though it is probably no harm, > the code here does not check debugfs_initialized(). >> +static int __init tool_init(void) > > This should be pp_init() not tool_init(). Yup, this is just sloppy copying on my part. I copied from two different places. I'll fix these oversights. Thanks, Logan