From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753139AbcFLCJk (ORCPT <rfc822;w@1wt.eu>);
	Sat, 11 Jun 2016 22:09:40 -0400
Received: from lucky1.263xmail.com ([211.157.147.131]:41408 "EHLO
	lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752113AbcFLCJi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 11 Jun 2016 22:09:38 -0400
X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S;
X-MAIL-GRAY: 1
X-MAIL-DELIVERY: 0
X-KSVirus-check: 0
X-ABS-CHECKED: 1
X-SKE-CHECKED: 1
X-ADDR-CHECKED: 0
X-RL-SENDER: ykk@rock-chips.com
X-FST-TO: dri-devel@lists.freedesktop.org
X-SENDER-IP: 103.29.142.67
X-LOGIN-NAME: ykk@rock-chips.com
X-UNIQUE-TAG: <042f5a86fdbf6c6610d0ebe65ca2c226>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG
 LP097QX1-SPA1 2048x1536 panel
To: Emil Velikov <emil.l.velikov@gmail.com>
References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com>
 <1465386753-27730-1-git-send-email-ykk@rock-chips.com>
 <CACvgo50T++tDB-kC4=ZMRpHPxOoqn_E8+=LVbj7n_HOUgeTaMA@mail.gmail.com>
Cc: David Airlie <airlied@linux.ie>, Thierry Reding <thierry.reding@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>, Kumar Gala <galak@codeaurora.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        devicetree <devicetree@vger.kernel.org>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>
From: Yakir Yang <ykk@rock-chips.com>
Message-ID: <575CC44C.5030702@rock-chips.com>
Date: Sun, 12 Jun 2016 10:09:16 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <CACvgo50T++tDB-kC4=ZMRpHPxOoqn_E8+=LVbj7n_HOUgeTaMA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Emil,

On 06/08/2016 08:20 PM, Emil Velikov wrote:
> Hi Yakir,
>
> On 8 June 2016 at 12:52, Yakir Yang <ykk@rock-chips.com> wrote:
>> The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
>> connected using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2: None
>>
>>   drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 3a7bdf1..41020e1 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = {
>>          },
>>   };
>>
>> +static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
> I believe that lg_lp097qx1_spa1 should be moved/sorted before lg_lp120up1.

Ah, yes, done  :)

>> +static const struct panel_desc lg_lp097qx1_spa1 = {
>> +       .modes = &lg_lp097qx1_spa1_mode,
>> +       .num_modes = 1,
>> +       .size = {
>> +               .width = 2048,
>> +               .height = 1536,
> These are the physical dimensions of the panel. From the documentation
> (at the top of the file)
>
> @width: width (in millimeters) of the panel's active display area
> ...

Got it, this should be the "display area"
Display area     262.656(H) X 164.16(V)         (12.2”diagonal)

Thanks,
- Yakir

>
> Thierry, perhaps it's worth renaming 'size' it to
> "physical_{size,dimensions}" and/or alike to make it clearer ?
> Looks like we have a few cases were people got confused -
> innolux_zj070na_01p and samsung_ltn101nt05.
>
> Regards,
> Emil
>
>
>