From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964847AbcFMHqZ (ORCPT ); Mon, 13 Jun 2016 03:46:25 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:65112 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932165AbcFMHqW (ORCPT ); Mon, 13 Jun 2016 03:46:22 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed X-AuditID: cbfec7f5-f792a6d000001302-7d-575e64cb9353 Content-transfer-encoding: 8BIT Message-id: <575E64C9.6060302@samsung.com> Date: Mon, 13 Jun 2016 09:46:17 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 To: Stephan Linz Cc: linux-leds@vger.kernel.org, linux-ide@vger.kernel.org, Joseph Jezak , =?UTF-8?B?SsO2cmcgU29tbWVy?= , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/7] powerpc: use the new LED disk activity trigger References: <20160610060021.12382-1-linz@li-pro.net> <20160610060021.12382-3-linz@li-pro.net> In-reply-to: <20160610060021.12382-3-linz@li-pro.net> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsVy+t/xa7qnU+LCDZ6f4LL40NTKbDH/yDlW i/43C1ktzr1ayWhxflk7kPWgh9ni2I5HTBaXd81hs9j6Zh2jxe/v/1gtrr5exGKx9PpFJost DYfYLNYcWcxuMWH6WhaL1r1H2B0EPJY0b2byWDNvDaPH5b5eJo9FLxtYPC5/f8PssXL5FzaP njctrB6bVnWyeex+m+pxfsZCRo+5u/oYPT5vkgvgieKySUnNySxLLdK3S+DKmLn/E2PBW82K UwtmsjUw/lXsYuTkkBAwkXhzfzULhC0mceHeerYuRi4OIYGljBK/75xjB0nwCghK/Jh8D6iI g4NZQF7iyKVskDCzgJnEo5Z1zBD1zxglntxohKrXkljduZgRxGYRUJV4O3krG4jNJmAo8fPF ayYQW1QgQuLP6X2sILaIgJLEpCet7CCDmAU2skgsvn0brEhYwEvi18LnzCC2kEC8xOGby8Bs TgFTibvXjjBPYBSYheS+WQj3zUJy3wJG5lWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsYITH4 dQfj0mNWhxgFOBiVeHg1VsWGC7EmlhVX5h5ilOBgVhLhXZoQFy7Em5JYWZValB9fVJqTWnyI UZqDRUmcd+au9yFCAumJJanZqakFqUUwWSYOTqkGxpUm5+ZW7lPaEbZ06oI/QpelHY5kCWgv XdBU8SGxqV/HlP/bPMWg4zZPTqyP5z5bY3GzoE/8zky3+NdBdy4GPHzkXel1We5SzGu78rI/ hi3iixzPTt+2UuLsHaO1xgYuWrw/Rc+euL2xrVGv13R1GsutzQK9xzlZuD4tb5ovWCeTfPj6 yuO3RJRYijMSDbWYi4oTAU2R0o69AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, For consistency reasons this patch should be merged through LED tree, but I need an ack from relevant maintainer. Benjamin, Michael, Paul? Thanks, Jacek Anaszewski On 06/10/2016 07:59 AM, Stephan Linz wrote: > - dts: rename 'ide-disk' to 'disk-activity' > - defconfig: rename 'ADB_PMU_LED_IDE' to 'ADB_PMU_LED_DISK' > > Cc: Joseph Jezak > Cc: Jörg Sommer > Signed-off-by: Stephan Linz > --- > arch/powerpc/boot/dts/mpc8315erdb.dts | 2 +- > arch/powerpc/boot/dts/mpc8377_rdb.dts | 2 +- > arch/powerpc/boot/dts/mpc8378_rdb.dts | 2 +- > arch/powerpc/boot/dts/mpc8379_rdb.dts | 2 +- > arch/powerpc/configs/pmac32_defconfig | 2 +- > arch/powerpc/configs/ppc6xx_defconfig | 2 +- > drivers/macintosh/Kconfig | 13 ++++++------- > drivers/macintosh/via-pmu-led.c | 4 ++-- > 8 files changed, 14 insertions(+), 15 deletions(-) > > diff --git a/arch/powerpc/boot/dts/mpc8315erdb.dts b/arch/powerpc/boot/dts/mpc8315erdb.dts > index 4354684..ca5139e 100644 > --- a/arch/powerpc/boot/dts/mpc8315erdb.dts > +++ b/arch/powerpc/boot/dts/mpc8315erdb.dts > @@ -472,7 +472,7 @@ > > hdd { > gpios = <&mcu_pio 1 0>; > - linux,default-trigger = "ide-disk"; > + linux,default-trigger = "disk-activity"; > }; > }; > }; > diff --git a/arch/powerpc/boot/dts/mpc8377_rdb.dts b/arch/powerpc/boot/dts/mpc8377_rdb.dts > index 2b4b653..e326139 100644 > --- a/arch/powerpc/boot/dts/mpc8377_rdb.dts > +++ b/arch/powerpc/boot/dts/mpc8377_rdb.dts > @@ -496,7 +496,7 @@ > > hdd { > gpios = <&mcu_pio 1 0>; > - linux,default-trigger = "ide-disk"; > + linux,default-trigger = "disk-activity"; > }; > }; > }; > diff --git a/arch/powerpc/boot/dts/mpc8378_rdb.dts b/arch/powerpc/boot/dts/mpc8378_rdb.dts > index 74b6a53..71842fc 100644 > --- a/arch/powerpc/boot/dts/mpc8378_rdb.dts > +++ b/arch/powerpc/boot/dts/mpc8378_rdb.dts > @@ -480,7 +480,7 @@ > > hdd { > gpios = <&mcu_pio 1 0>; > - linux,default-trigger = "ide-disk"; > + linux,default-trigger = "disk-activity"; > }; > }; > }; > diff --git a/arch/powerpc/boot/dts/mpc8379_rdb.dts b/arch/powerpc/boot/dts/mpc8379_rdb.dts > index 3b5cbac..e442a29 100644 > --- a/arch/powerpc/boot/dts/mpc8379_rdb.dts > +++ b/arch/powerpc/boot/dts/mpc8379_rdb.dts > @@ -446,7 +446,7 @@ > > hdd { > gpios = <&mcu_pio 1 0>; > - linux,default-trigger = "ide-disk"; > + linux,default-trigger = "disk-activity"; > }; > }; > }; > diff --git a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig > index ea8705f..3f6c9a6 100644 > --- a/arch/powerpc/configs/pmac32_defconfig > +++ b/arch/powerpc/configs/pmac32_defconfig > @@ -158,7 +158,7 @@ CONFIG_ADB=y > CONFIG_ADB_CUDA=y > CONFIG_ADB_PMU=y > CONFIG_ADB_PMU_LED=y > -CONFIG_ADB_PMU_LED_IDE=y > +CONFIG_ADB_PMU_LED_DISK=y > CONFIG_PMAC_APM_EMU=m > CONFIG_PMAC_MEDIABAY=y > CONFIG_PMAC_BACKLIGHT=y > diff --git a/arch/powerpc/configs/ppc6xx_defconfig b/arch/powerpc/configs/ppc6xx_defconfig > index 99ccbeba..1dde0be 100644 > --- a/arch/powerpc/configs/ppc6xx_defconfig > +++ b/arch/powerpc/configs/ppc6xx_defconfig > @@ -442,7 +442,7 @@ CONFIG_ADB=y > CONFIG_ADB_CUDA=y > CONFIG_ADB_PMU=y > CONFIG_ADB_PMU_LED=y > -CONFIG_ADB_PMU_LED_IDE=y > +CONFIG_ADB_PMU_LED_DISK=y > CONFIG_PMAC_APM_EMU=y > CONFIG_PMAC_MEDIABAY=y > CONFIG_PMAC_BACKLIGHT=y > diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig > index 3e8b29e..d28690f 100644 > --- a/drivers/macintosh/Kconfig > +++ b/drivers/macintosh/Kconfig > @@ -96,19 +96,18 @@ config ADB_PMU_LED > Support the front LED on Power/iBooks as a generic LED that can > be triggered by any of the supported triggers. To get the > behaviour of the old CONFIG_BLK_DEV_IDE_PMAC_BLINK, select this > - and the ide-disk LED trigger and configure appropriately through > - sysfs. > + and the disk LED trigger and configure appropriately through sysfs. > > -config ADB_PMU_LED_IDE > - bool "Use front LED as IDE LED by default" > +config ADB_PMU_LED_DISK > + bool "Use front LED as DISK LED by default" > depends on ADB_PMU_LED > depends on LEDS_CLASS > depends on IDE_GD_ATA > select LEDS_TRIGGERS > - select LEDS_TRIGGER_IDE_DISK > + select LEDS_TRIGGER_DISK > help > - This option makes the front LED default to the IDE trigger > - so that it blinks on IDE activity. > + This option makes the front LED default to the disk trigger > + so that it blinks on disk activity. > > config PMAC_SMU > bool "Support for SMU based PowerMacs" > diff --git a/drivers/macintosh/via-pmu-led.c b/drivers/macintosh/via-pmu-led.c > index 19c3718..ae067ab 100644 > --- a/drivers/macintosh/via-pmu-led.c > +++ b/drivers/macintosh/via-pmu-led.c > @@ -73,8 +73,8 @@ static void pmu_led_set(struct led_classdev *led_cdev, > > static struct led_classdev pmu_led = { > .name = "pmu-led::front", > -#ifdef CONFIG_ADB_PMU_LED_IDE > - .default_trigger = "ide-disk", > +#ifdef CONFIG_ADB_PMU_LED_DISK > + .default_trigger = "disk-activity", > #endif > .brightness_set = pmu_led_set, > }; > -- Best regards, Jacek Anaszewski