From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424011AbcFMPMf (ORCPT ); Mon, 13 Jun 2016 11:12:35 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:25063 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1423555AbcFMPMd (ORCPT ); Mon, 13 Jun 2016 11:12:33 -0400 Subject: Re: [PATCH 00/30] DRBD updates To: Philipp Reisner , References: <1465826958-19398-1-git-send-email-philipp.reisner@linbit.com> CC: From: Jens Axboe Message-ID: <575ECD32.2080700@fb.com> Date: Mon, 13 Jun 2016 09:11:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465826958-19398-1-git-send-email-philipp.reisner@linbit.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CY1PR12CA0003.namprd12.prod.outlook.com (10.160.137.13) To SN1PR15MB0462.namprd15.prod.outlook.com (10.163.205.16) X-MS-Office365-Filtering-Correlation-Id: 4be1bdbc-eaa4-4ef1-b8c4-08d3939d0d42 X-Microsoft-Exchange-Diagnostics: 1;SN1PR15MB0462;2:VLhkj34CwQ7QWvm8qBPJ/uvfY67dfYhEsHr2zvpwIqyj3ZUSe39dyDP4iKS2l3xMLQPoDwoRFtGXirWlTdzZVcDYbgW0bVFlFRs7x0yCNQJ1B9Sv/frySjywSSmDp0QizVXpSou5E9AA54o/KYl6iNpSTKlSOvBmhOE3YahSDA7kRjjD2MeGQvGiGz3IZfa9;3:rTYl/ZkgXkZNjNAisrxu+qpvpLmfRZA8QvJeN9yRxl+WeOVw3rdz2gb4+wIYySbv9fBx6MaPxGSm3Uqqvu7SwPfnNjV0efMWeDpmrcsj7505YuNYgAadINYI1tO6UYEg X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR15MB0462; X-Microsoft-Exchange-Diagnostics: 1;SN1PR15MB0462;25:mSxoj2r1K1sRZfOLslvnRq8Oe5td9ymTvg1NbM/SI/ovggNizxh632PU3VLIb8bbOVvhlYVuDqlSYsEj5WrfR4OnnHI14x5Rars5RvpOGjm2lirUvwyh9EQZy+89tDZMxyKRtme4ZqADC3uNL6Jeb9CYFmF+PuEqggaWg/I117IdJmQ08RuA/BEre4FVG2mq4DZr6Owti8X5EUHH/v8YQTM9YzZlv3OivuFRFQ1+92Fp3OulzQI6lT0Df6H35A1gTXeTRLFbumOfW3hgoVLnAcAxPK1wLwl4VciVRbEH+k/jxIg6uoFRAQCXA9rq5cSUV3dFjYNnXOdzPQBfXGvSbLdR2fB1dunxmDUrgFXsU6vC8OJYlNCdJncP1S9XBNVKIo2cHRkU7/SAw7nUr2qTqXxN17TySOvI16kCLf9YMT/rB2gLPuskNkx9+lVHSm7/fpHvTeqbeVfRDscwaOYU5ExJ2civC93UMN5NRghZ6lv2f+OWw36FQAlKxfZf0sWJGsFU4IuFIfzfTRhghqmvN4hlFh4cGoePR4qnadnj4qpwR0UjM57Sn0HuUu7zehOkIBuCD0EY9fewXDh57qyGqPDKv9iviDEUExvQ3EKkPju9nqd7Uk54OUu4KOUCAa6moAzhskcdhd6lvNjvhUh1blrAGUV9JMSIrw9MZFYI3jsw8HxITusYsGGTvpLBppVbz6BLCYLjHBE67+S0SMvpzA==;20:xhs0wJ+utzL5w7Fii+BGDRc3aK0APa1acuVkT7SHLw7LC92o+6ToZatdwysiPJx3tRXcj4XXZGjauAfyS42eSRxe9tbdBtK2NTJaHpPiu0TkoEWIo9SD0b+ik5699bnXxLEcUp8NsSwf+zJvuoPNwniz1OOTF3m35oWCQW05VEc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:SN1PR15MB0462;BCL:0;PCL:0;RULEID:;SRVR:SN1PR15MB0462; X-Microsoft-Exchange-Diagnostics: 1;SN1PR15MB0462;4:PHIBckFTeE+cbO7rHrR/UalWdHVpHANT2xqm+M/H1i5/CcVCJSn89xsrvab1s7SxUNAgGCF5zvxAFnrzXnX1bTdaVT+UC00abgjpl6wIVKKr4OwkdZ4iRBr6yY6RKE6zxhOLY/emOG1Nc5qg2ndHFH5nzjKvC+gXfzLi2ElMuHo8G7Vyh3IWHV3tFXC3HokEq5+QtTnjjV7O0hP8nwbRO3RW/sl68TOGYV/14ZrDep/9/yyCJe5sknWWjqkWOXOT/jGTG9XQvk+aSHIwkAXEm/BHR11ewLokZdnhuBcPESpO6Wl8uyCwtp0NSgeew0Kxx6R/isKlkFrDNt6PwzJCUHiwoizSShjN1dXFttXSsRG15b24RmC0iXPiIVaKbc1U X-Forefront-PRVS: 0972DEC1D9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(377454003)(24454002)(189002)(4001350100001)(65816999)(5001770100001)(68736007)(97736004)(50986999)(54356999)(76176999)(230700001)(33656002)(5008740100001)(87266999)(83506001)(2950100001)(81156014)(81166006)(59896002)(77096005)(4326007)(36756003)(6116002)(3846002)(117156001)(106356001)(189998001)(586003)(105586002)(80316001)(50466002)(47776003)(92566002)(42186005)(5004730100002)(64126003)(65956001)(66066001)(101416001)(86362001)(8676002)(23746002)(65806001)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR15MB0462;H:[192.168.1.130];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR15MB0462;23:LcAkszkmMoaMEP1EiHRBkykWH09LfE/hCD7s8?= =?Windows-1252?Q?4Srg0BC2y6XFC1E4kf9z8YP21ImU9K/0SSXn5lzvswUBipEvvfk7phKk?= =?Windows-1252?Q?DVGt+AjKb5gUiUyT6ksLbMw0zAGpubSFnE9dCdwUQLu+2zXHIeDiYWGm?= =?Windows-1252?Q?Gmdo7ssqCuZz3/C/gXeN5PkoMN3zldseSDxJz3nUcOsoPlPGGPQvjJc8?= =?Windows-1252?Q?rNAnyl6PBFywNhcUBFXD6y0dCBhZ1BhXn29Ib57iz6ArCWlhP3SNKTEu?= =?Windows-1252?Q?/sxOHjsw9PfZ7k9XXetLvz1ITq09lapbfq2OUdzzDT6JTidzTFeCccGy?= =?Windows-1252?Q?YB1l3mxkC1qlRQFz1YF4hQZGDC0ANFbzX4KgXHMp67Sbiln2JOVZXLyg?= =?Windows-1252?Q?U8oK4IxFuF4PCfBAH0Ol8WLTG6dICzgi63ZrvPk+zgqhe0x9PkEnc4+m?= =?Windows-1252?Q?xQ6rL6dU0Qk8WeqFU6PuhWxjpmtSsRRfH4m8x5cGcYZXkSrSQaAK4i+I?= =?Windows-1252?Q?zd32dnHJVK/ytosrZgTxiD0g1l6r/Mk4hqHFQJvfouAKOwtUzsNiV3q/?= =?Windows-1252?Q?2uCutBV6FDr08S1uJ7+WKoUXww/sVvTpytaExgcHypsCHRX9pFYRizQ7?= =?Windows-1252?Q?9jfjuQiIA42mtHIrF+fb17LgCVO0hlU495+Y4USqabqjdaYuE7u2pHXF?= =?Windows-1252?Q?8mZNSLfUE+O6FpIZ/L0KWqlZGftX1CSlysNyDh3/nlJtzxL7ea1UdMXj?= =?Windows-1252?Q?vLEv/vZqj8DO0anocl8ZXMNS+LJyC5SlXlGnX5Ze4ymgVkZZgjA6s1qc?= =?Windows-1252?Q?4Nuj1j2KFAR0NielMbfeAzFL6GzGENhAgKTZRPVSBPkFQJ9HhduSj5wx?= =?Windows-1252?Q?GJZF/l+A+HPtqZ3KMoaWLvpO8oQ8KQtaij7APqYq2iBTbl+VfRCu1tsE?= =?Windows-1252?Q?pAHoWxVJkmxYMBCksIginZ3CP5undssO3wGyCJEscYgrQpNO0+SVgQS7?= =?Windows-1252?Q?OxnFffXCnblHK6cc3lJPOrOsGWKIMGmgTL4HmMIoMf3+Tw+qonlxSMmN?= =?Windows-1252?Q?NScIE+A8zpV/G150FJMpOQw3/vLfV8Ms5gWBxX5yiw8z1EadP4NYOGtq?= =?Windows-1252?Q?MXZSo363IQGOE8rCHuFn5eCbXHeYgKNYrLM+f5Tz5Igkf30A+uEB3i8M?= =?Windows-1252?Q?C8z90oGVnMhXeoiu3fGkYH/FQ8fVLIX+AaoebsJNKYQaTK+BUpiVs5/+?= =?Windows-1252?Q?vIs01AbxbSY54oaxTltZPhUIOP0rcpSP2LzH5L44FBKMKFaOUFwcyZZw?= =?Windows-1252?Q?oQfIkJqU9I14G9BBM3/CyIMOAN+0lDJ8QM2rwEg6ACFpCcLE0vpOaakI?= =?Windows-1252?Q?Kx2T0xpZ2jM?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR15MB0462;6:GCbMU6phLZKHplOx138bV88/m9g0ToThqFYo1kORsFZ+3DwUG5yTZ913r4wm77jM9OLj2NBkt2EIpgW9zjeX/HKSxI0CjIA891TvyRycUh7ogj5d9+G7SoOE4NUar9WJCr+gjE6FmreTInp7Stz+wdrZqKI5piRR9JO2S4DaCA5Wk1W/cwd7HWh2tacoKlWW8PsIY/1360M+gmyWE1OzaD6dFot4+Do9N2xBa+ChAuSJp1voUxUQokM5ccwVOv7LzVyuztdA2gjBvj3iLkg5OWLIMUHNFLFfzyFAHk5TmLM=;5:BCKGhx/udW9fZ8BuixPhwiFFFOwA2XN/uQzm/GMLxyuJxdL8uRtaEDKq7nCygOtMO/ni10uptVK60jM64+/BasyX3rfAo7K7c1HVMtQTavAzPvSDTaSqScZqMj5A0yAsR5SkS/+BfkSbppIxiKgekw==;24:+iserwJICynHM5viBE5ybJJeL5s3y6slOsqboVuFb0MQVbVsnaCkjRADUQb1SSIuT/xP+RIov4BOeI6Y40+/AijzEFvxkq852GRcNDg4p6Q=;7:rlPjK0+QIIM5Bq0POund7fDfEgGDNn3zXQjp0tI79WB8UanHQHuW83f4YepgxzTQ/6Rmpefj6EqJ6oooPySDCYamllTlCUZ53WXhajXwMxb1qSFe/IHLJRaMyh+d47bizqII2v0ykwdZO93rm4X7kzNMCqRwwgxi58s/h73rsggqI+MR1HarusXjBBnBmC5wbr66Yc67HwIIqSY8X5NCDJ72x7jfSHrdCToZspLJzyg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR15MB0462;20:oCZn4O/+gsVbfElPJHUATr1RCAWnLSbMLXbgBs21IHkqxtRRVugDJCqLXgtBm+kPLKFQjhLrufqcVPzlOtBHPWWzDPbhW/MVktg7mw1O++UfaTGFuYrpoCzF+0pQyFuAiVLdZTrZvY1ya6GhmsO9pBbqtufc9J1RXg42nv3uHzI= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2016 15:11:52.8496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR15MB0462 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-13_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/13/2016 08:08 AM, Philipp Reisner wrote: > Hi Jens, > > I have sent this already on April 25, I guess it was too late in the cycle > at that time. Apart from the usual maintenance and bug fixes this time comes > support for WRITE_SAME and lots of improvements for DISCARD. > > At that time we had a discussion about (1) the all_zero() heuristic introduced > with [PATCH 04/30] drbd: Implement handling of thinly provisioned storage... > not being efficient, and about the (2) rs-discard-granularity configuration > parameter. > > Regarding (1): I intend to work on block-devices being able to export their > allocation map by either FIEMAP or SEEK_HOLE/SEEK_DATA or both for the next > cycle. The I will change DRBD to use that as well. > > Regarding (2): We need to announce the discard granularity when we create the > device/minor. At might it might be that there is no connection to the peer > node. So we are left with information about the discard granularity of the > local backing device only. Therefore we decided to delegate it to the > user/admin to provide the discard granularity for the resync process. > > > Please add it to your for-4.8/drivers branch. If you want me to add it to that branch (which is where it should go), then why aren't the patches against that branch? I get rejects on several of the patches, mainly because they are not done on top of this particular branch. We can do two things here. I can skip patches, I don't like doing that. Or you can respin against the proper branch, as it should have been from the beginning. What do you want to do? -- Jens Axboe