From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v1 4/6] clk: qcom: Add graphics clock controller driver for SC7280
Date: Tue, 27 Apr 2021 15:18:20 +0530 [thread overview]
Message-ID: <575a9235-7753-d589-2173-050a16063b71@codeaurora.org> (raw)
In-Reply-To: <161786654585.3790633.12597782416303763853@swboyd.mtv.corp.google.com>
Hello Stephen,
Thank you for your review.
On 4/8/2021 12:52 PM, Stephen Boyd wrote:
> Quoting Taniya Das (2021-03-16 18:22:20)
>> +static struct clk_regmap_div gpu_cc_hub_ahb_div_clk_src = {
>> + .reg = 0x11c0,
>> + .shift = 0,
>> + .width = 4,
>> + .clkr.hw.init = &(struct clk_init_data) {
>> + .name = "gpu_cc_hub_ahb_div_clk_src",
>> + .parent_data = &(const struct clk_parent_data){
>> + .hw = &gpu_cc_hub_clk_src.clkr.hw,
>
> Can you follow what Dmitry has done and use .hws instead of
> clk_parent_data when the whole array is clk_hw pointers?
>
Will update them in the next patch.
>> + },
>> + .num_parents = 1,
>> + .flags = CLK_SET_RATE_PARENT,
>> + .ops = &clk_regmap_div_ro_ops,
>> + },
>> +};
>> +
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2021-04-27 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 1:22 [PATCH v1 0/6] Add support for DISP/VIDEO/GPU CCs for SC7280 Taniya Das
2021-03-17 1:22 ` [PATCH v1 1/6] dt-bindings: clock: Add SC7280 DISPCC clock binding Taniya Das
2021-03-26 0:11 ` Rob Herring
2021-04-27 9:48 ` Taniya Das
2021-03-17 1:22 ` [PATCH v1 2/6] clk: qcom: Add display clock controller driver for SC7280 Taniya Das
2021-03-17 1:22 ` [PATCH v1 3/6] dt-bindings: clock: Add SC7280 GPUCC clock binding Taniya Das
2021-03-17 1:22 ` [PATCH v1 4/6] clk: qcom: Add graphics clock controller driver for SC7280 Taniya Das
2021-04-08 7:22 ` Stephen Boyd
2021-04-27 9:48 ` Taniya Das [this message]
2021-03-17 1:22 ` [PATCH v1 5/6] dt-bindings: clock: Add SC7280 VideoCC clock binding Taniya Das
2021-03-17 1:22 ` [PATCH v1 6/6] clk: qcom: Add video clock controller driver for SC7280 Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575a9235-7753-d589-2173-050a16063b71@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).