From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E99C433E7 for ; Tue, 13 Oct 2020 19:48:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2ABBB20E65 for ; Tue, 13 Oct 2020 19:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728632AbgJMTsx (ORCPT ); Tue, 13 Oct 2020 15:48:53 -0400 Received: from smtprelay0202.hostedemail.com ([216.40.44.202]:54066 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727665AbgJMTsx (ORCPT ); Tue, 13 Oct 2020 15:48:53 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 789CC180A8142; Tue, 13 Oct 2020 19:48:51 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: grain34_5e09cac27205 X-Filterd-Recvd-Size: 1906 Received: from XPS-9350 (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Tue, 13 Oct 2020 19:48:50 +0000 (UTC) Message-ID: <575e7e2eb77ee5c26c3ac8fb6cb863890e971a16.camel@perches.com> Subject: Re: sysfs filenames with spaces From: Joe Perches To: Pavel Machek Cc: LKML Date: Tue, 13 Oct 2020 12:48:49 -0700 In-Reply-To: <20201013171754.GA29185@duo.ucw.cz> References: <9b6f5c32d244131dbd63b55b085b3b4173144b4b.camel@perches.com> <20201013171754.GA29185@duo.ucw.cz> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-10-13 at 19:17 +0200, Pavel Machek wrote: > On Mon 2020-10-05 19:41:15, Joe Perches wrote: > > This doesn't seem like a great idea to me. > > > > For my system I've got: > > > > /sys/devices/platform/Fixed MDIO bus.0/ > > /sys/bus/platform/drivers/int3401 thermal/ > > /sys/bus/platform/drivers/int3403 thermal/ > > /sys/bus/platform/drivers/int3400 thermal/ > > /sys/bus/mdio_bus/drivers/Generic PHY/ > > /sys/bus/mdio_bus/drivers/Generic Clause 45 PHY/ > > /sys/bus/pnp/drivers/i8042 aux/ > > /sys/bus/pnp/drivers/i8042 kbd/ > > /sys/bus/i2c/drivers/CHT Whiskey Cove PMIC/ > > > > Could these filenames be avoided in the future or > > even renamed today? > > Does not look like great idea to me, either. Hmm. Is there filename > with "/" in it? :-) > > But I guess you'd need to cc relevant maintainers and that this is > going to be a bit of whack-a-mole. An option might be to convert any invalid filename via an alloc and substitution in sysfs_add_file and similar free in sysfs_remove_file. Emitting a logging message describing any new name would be useful too.