From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbcFNQWt (ORCPT ); Tue, 14 Jun 2016 12:22:49 -0400 Received: from mail-bl2on0093.outbound.protection.outlook.com ([65.55.169.93]:48787 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752478AbcFNQWr (ORCPT ); Tue, 14 Jun 2016 12:22:47 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Message-ID: <57602F4F.8040104@caviumnetworks.com> Date: Tue, 14 Jun 2016 09:22:39 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Jiri Slaby , Peter Hurley , Ming Lei , Dann Frazier , Scot Doyle , David Airlie , , , Pavel Machek , , David Daney , Subject: Ping: [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer. References: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: SN1PR07CA0041.namprd07.prod.outlook.com (10.162.170.179) To DM3PR07MB2138.namprd07.prod.outlook.com (10.164.4.144) X-MS-Office365-Filtering-Correlation-Id: 98723628-7000-443d-652a-08d394701d26 X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2138;2:Jmtc8oCYkvUExzcSp0E05yWIl5c3ZEWRh9f2lWlNytNTW1Cw3UveJ7oelfaNPgTelzvc/lnV1aaU9tBeSl5rnQPCbXShJYEKrybW0HHbMKZ+1+TUj8JpLK12+NqqVOqG9ScxyhO+QFfI6iCawG2evqPekN3OXRET8S+e4Rb3YKqCyAXcYKrbc2G8S3lpK9fT;3:noLXp93Y7L0O4uM2a/BFeiCoQtoDld86vN2SBDsRkYtCmFXQaFiUtxsoqMpudFGEocXRulwQ7PNHWbaT7tNseuM91yqeha7pgQ3ZHftLumua0wnLdnaFDG8Brva2wiaU;25:ANMggv1qc6RCivaY4BStI5j1W9McVu3rr9KapGFVlZ5whGNLfPWvwYM2+XnjFkR82VAXNNub5XVELo5NxGZmYp5tB9ykfOXNX2BAAR17+Iytnp/m+H8v6fx1iBzyuFe5eDzU3F4pmxfzkWdjUIzC1erUl4efQdWodY0v6wMghRucXN74aViipZIyRabVbZsGJfmGjLAMIKeyBCz6hxGnwDHDwFcG7bc8ZkezhyRxV5oZItpuJVitAQPRklk6kYfqeJ/+x/mM81E/4YWV6JVkq0z8Zkuup23A7aBpjURk8vE9v1H9VrL5QujRzGuc/u1Z4SW8/zF3ga6fMcnNvQMbcJz/SjwapeLXQh0z4uui7yOPL0dHnUWisKbKU3ei8E/KvATG5sttIX6LgYpvGKAZFo+/t37lab5hV78JL2RS+VM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2138; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2138;20:AO0RPiYMEuL18f+lyVfGObjU0Ib24v+RO2CpT8MQB02V3rP4djc8PcIdOv6Tlw4G89rM0nDVpKNgqTPdFSbQch7Fs/hfu/cwZ/YGKNkYPmOzu46lYYdWKIBDBKBzu4V1R7XoLsQ6yu7DBSDNfdzWqkSowXScl3AwglsxRht6bcMK1sDhRqZX/zmv3fMJkjEa3VUv+3hJ4ex2apSJ16k/9/iwbMyWAWF8XJjNTMRSdTM2rU0E5k42wM2WWaQgjItdQ5EEQNsqEvqa+2UshbRVTzhmk6WoIsIei96ZrznTjFNzWO//QZxmf/+mS4QOnOk+MMbpWHp2CS4Av6pavWL6a402yfQOKMwUFUZlr513NfOIeb7hLDYGRyGy4wvaRDXJuJh0tWT2tdIiQHBJyiCjSt4XQMwUodpB2Iq3hTyRU9mG6P2Mi15EqP0pfeTwRK9oUhtc3bgl4WfkD/VoSd8N73/uggOV+ewuDyD2fNu+HqsiSK7fcRSqP3GE/O3xdXRk8cns4rkQvN94mLzjROk2ccyiZK1ZoMaKtXwrEIkjDJOIBmR851inJt54kTwaUqzbBf7O5aP2HpDxKseDi+KCIr3KBL9g/kUTlbpv04Yjhfw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:DM3PR07MB2138;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2138; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2138;4:3Fd+LuVXVnr+Pfg5SC7Xi18+9O3koq0nqM1wlEz8VJ+n8EgFj+AgxnB2ZtqdalPmEq8Ew8Vc3saiAVBbxLy2MCUp6DuOz0yBW5f4ZpaWldov29Bxh92QgU7nL+/WN0h4YHuXBVUCM8xHtPTtbjvgyhgKB7J45a+RwPAi4Tlslhl7za0k8I+ABzLjeoUSRyeSEX2IKH5MD/hLf4tRIfnOYBzpQJ9vLCli4WXCKVjnC2ScIIaXN3bOBkxaVBKbrF5EjrV5b2aL9dgRhzdEH+4z62qjaqBllXH+TSzjsjceUwPVAqughxPCs8fH9EVqDTuk7+467iJRfS0bpWmJ5vbI95C2jBO0pgmJjPhkYp0WtrVPh7YCukFOHLYh7zC4jDtMSSXhCOMBm4Y6WZJLrFRGeP+7x///RWiP52poHmOd610= X-Forefront-PRVS: 09730BD177 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(377454003)(199003)(189002)(51874003)(47776003)(53416004)(42186005)(4326007)(50466002)(66066001)(59896002)(2906002)(106356001)(105586002)(586003)(3846002)(6116002)(83506001)(19580405001)(5004730100002)(77096005)(64126003)(36756003)(99136001)(19580395003)(65816999)(76176999)(54356999)(87266999)(69596002)(2950100001)(189998001)(23756003)(33656002)(101416001)(5008740100001)(92566002)(65806001)(81166006)(229853001)(81156014)(65956001)(8676002)(50986999)(97736004)(80316001)(230700001)(110136002)(68736007)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2138;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM3PR07MB2138;23:uzbx4dgnrqJ8ca2reJTgCL4iEbGdZkQHX6RZ5ML?= =?iso-8859-1?Q?qyc0b3iOXig0PbIhp2DVaTN7R5gQZSgsdot8UpsIIGtkHVWke97MqbBgs8?= =?iso-8859-1?Q?2IsVvMeQWAfk07zB0lk9LGvThV6iGDhBgNB27tRs0BJoiPreOReLe9syl6?= =?iso-8859-1?Q?UASLDBceL8KdEyj1diY2fXRoOoH6HWMMjPXrO44WUAEcQpkuc8iBbjZU9q?= =?iso-8859-1?Q?bU50Kc2KC+kZD2qenpLFHAaoGv6t5U4ovfd6kSUeMj5gaBL8grlVpwi5qe?= =?iso-8859-1?Q?bw77B+saBs7dn8VAcfYanMZ+c+9Rk+Qkf4L0vRtJATQ88Z8QP5rncNxiJT?= =?iso-8859-1?Q?aPTUSfAdw9omcK6gg1FFMngIlLnImto/ofouHGckbnrlBPUqW/gL6iJlx6?= =?iso-8859-1?Q?ru44MfE4K3Q9m5hqSIhdkwHsxdws0ds19Q298V45FAAQt0fd09g7K/v3lB?= =?iso-8859-1?Q?DtA4SGFPNh3tMvbWENVVHSK72lANL4akVcwyX59ArGuZhmZXTNWoYaqmpm?= =?iso-8859-1?Q?tV3Pl8TUfJx+90PUqk+AhTYWFLVyjpVFkcSDHafkL7SyCbESGdrXiyh7YV?= =?iso-8859-1?Q?axh+xZhl6mQq9ERALa4cJxyOeO+pvnl1XNbT5B6hApRhKleaKQoszRZaM6?= =?iso-8859-1?Q?vytxHCiFuu+0Ymh3xroKM0PeBacMEeqHyx7JBG7WJkdoJ3jXvLk05mwr0r?= =?iso-8859-1?Q?qkNl1M88SgRjOoMn4QAFLRLnK03hMD/3JdgcLX5f+rkYIdVNId1EynJ1Jh?= =?iso-8859-1?Q?vIxRuM31y57jOMWtDExuwetqXINXDRQse9iaoDX+C1pSwk4epTZ2BveJk/?= =?iso-8859-1?Q?/TGOiiJGsuDwwMwqkxHK9Cd8VkhrQkcHzxIQVOsKXrmtfl1Hzle8jZhFk8?= =?iso-8859-1?Q?hNat3AFtdwjE+RD1AIlKV+alJBWaBipLr03IjcuKA0Z9i14wke14R1FmQ9?= =?iso-8859-1?Q?+k1SZv8QrowILrR43PVoety6npTwjhqLbjR/MnNeWwo5MKh5U0yl/h8mUC?= =?iso-8859-1?Q?92owd/BFdc+755XE1/owxrgvRqQ4d8nSwhv70jyStPbew0mq8a4B4LZ5UY?= =?iso-8859-1?Q?sTuZrV1aYKtIvlCkpPGJ8KTqNvCW/9CdTH4yiIB+gz7uYSsx0mZRjyU3Mc?= =?iso-8859-1?Q?6A7f+boU5fGkbojFYfQD+89iSGDnIaPSUZAt4WomXxiDYjxS3uMC3GS5s3?= =?iso-8859-1?Q?jV0aIvstGiEemuF0MhvIHnYbJMs8bxUHunc3cGbVP0+Vvird0G7+7LZcFQ?= =?iso-8859-1?Q?k8jhX4IsE7XUz93qQDDQ3pcU2/p9pRIclTcYtGCt1KbXWptqaJilUlhfFA?= =?iso-8859-1?Q?Of1yMWlhRjb7Lk5UN5onnEhyUMCghnmY5NXxeaC6s0OrRM9+R2KG+HZyBp?= =?iso-8859-1?Q?5Vv/kzNr7zhzijnupGhIqG6z14yY+S9hzMeAzil59E45zoXjhHg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2138;6:0VR6IyOUaV1dHzcRbuh4vlUhUqkFetjBhJ9l/iXeXDAB5KvN1peUOKF+B0LXMcmvufw1PgWGvRlIL64POw2wUN7B95Ofh2cxCusIIldCHGZUrLQyeHjxtDh2tRLNTk8fBrd9+oSdh2k9MfAC5AObjerR/pE7rIaVNy7OFUMMSUCWG2Coj6qzYVWMoetLxYo7fIzSfQE6eGrJnX3sJf70KtP/0KcaI2M1erb47DnpNO08gLoaHyATu2+/leAyxwVeufmriY97dRPgC3bNUfGZBw==;5:REAN2YxoNxJEMjGbZ2/OWfBo2MuzLkTnUnVvVVcZNzQi7JZ+G96yv4uVHq5fzrMWO+T4UoPOvs9KytgCQ9k5xHyN49pYNI/nJEwTnY0lt4RAX3Qsc+9H6KHiWwmtHRB8LximL02se5IveD+ganSTtQ==;24:TejlC6GaT1ajOIrp6JqTCKyvN5qKClzUZ3kSbzVNpzLi3jvTrjnDCExzgd78QgnCWQXTKuYNDCTJlpw6kiCdkIwUwaSBHGf/hbsWrBJJyno=;7:iIhrEr9W06X2+EUzI+cUJweHEbpUmMyP7iZOVV23w1Fcbl6WrMXborRSzTDm4WG84IcXDK2MQQMxNUw6h3d6OCchaaZuCifvioE4WwiLL5t9rY8JIh1W5gGx+axrV1W7p8j/Alab+W8eC1Y5mb/dQMUPLoCuOCpJPwT7vnkQlyjZ9nMcI9Ao3GHLJITIiOBdTzT4WbEhG8m+tzJp6p82lA== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2016 16:22:42.5016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg et al., Now that the merge window is closed, please consider this patch. Thanks in advance, David Daney On 05/17/2016 11:41 AM, David Daney wrote: > From: David Daney > > We are getting somewhat random soft lockups with this signature: > > [ 86.992215] [] el1_irq+0xa0/0x10c > [ 86.997082] [] cursor_timer_handler+0x30/0x54 > [ 87.002991] [] call_timer_fn+0x54/0x1a8 > [ 87.008378] [] run_timer_softirq+0x1c4/0x2bc > [ 87.014200] [] __do_softirq+0x114/0x344 > [ 87.019590] [] irq_exit+0x74/0x98 > [ 87.024458] [] __handle_domain_irq+0x98/0xfc > [ 87.030278] [] gic_handle_irq+0x94/0x190 > > This is caused by the vt visual_init() function calling into > fbcon_init() with a vc_cur_blink_ms value of zero. This is a > transient condition, as it is later set to a non-zero value. But, if > the timer happens to expire while the blink rate is zero, it goes into > an endless loop, and we get soft lockup. > > The fix is to initialize vc_cur_blink_ms before calling the con_init() > function. > > Signed-off-by: David Daney > Cc: stable@vger.kernel.org > --- > drivers/tty/vt/vt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c > index 3e3c757..eef5c36 100644 > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -750,6 +750,7 @@ static void visual_init(struct vc_data *vc, int num, int init) > vc->vc_complement_mask = 0; > vc->vc_can_do_color = 0; > vc->vc_panic_force_write = false; > + vc->vc_cur_blink_ms = DEFAULT_CURSOR_BLINK_MS; > vc->vc_sw->con_init(vc, init); > if (!vc->vc_complement_mask) > vc->vc_complement_mask = vc->vc_can_do_color ? 0x7700 : 0x0800; >