From: Shuah Khan <shuahkh@osg.samsung.com>
To: Yannick Brosseau <scientist@fb.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kernel-team@fb.com, Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests/exec: Add Makefile to install list since exec test expect it
Date: Tue, 14 Jun 2016 13:09:45 -0600 [thread overview]
Message-ID: <57605679.7080401@osg.samsung.com> (raw)
In-Reply-To: <1465929912-11516-1-git-send-email-scientist@fb.com>
On 06/14/2016 12:45 PM, Yannick Brosseau wrote:
> When running the execveat test once installed, the Makefile it not available and the
> test fail. Bundling the Makefile file with the installed files fix that.
Install is for installing kselftest binaries and run-time dependencies
if any on a target system. It is not for being able to build it on the
target. Bundling Makefile doesn't make sense.
-- Shuah
>
> Signed-off-by: Yannick Brosseau <scientist@fb.com>
> ---
> tools/testing/selftests/exec/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
> index 4e400eb..d2be580 100644
> --- a/tools/testing/selftests/exec/Makefile
> +++ b/tools/testing/selftests/exec/Makefile
> @@ -1,6 +1,6 @@
> CFLAGS = -Wall
> BINARIES = execveat
> -DEPS = execveat.symlink execveat.denatured script subdir
> +DEPS = execveat.symlink execveat.denatured script subdir Makefile
> all: $(BINARIES) $(DEPS)
>
> subdir:
>
next prev parent reply other threads:[~2016-06-14 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 18:45 [PATCH] selftests/exec: Add Makefile to install list since exec test expect it Yannick Brosseau
2016-06-14 19:09 ` Shuah Khan [this message]
2016-06-14 19:15 ` Yannick Brosseau
2016-06-14 19:22 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57605679.7080401@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=scientist@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).