From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbcFNTWK (ORCPT ); Tue, 14 Jun 2016 15:22:10 -0400 Received: from lists.s-osg.org ([54.187.51.154]:52933 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbcFNTWJ (ORCPT ); Tue, 14 Jun 2016 15:22:09 -0400 Subject: Re: [PATCH] selftests/exec: Add Makefile to install list since exec test expect it To: Yannick Brosseau , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <1465929912-11516-1-git-send-email-scientist@fb.com> <57605679.7080401@osg.samsung.com> Cc: kernel-team@fb.com From: Shuah Khan Message-ID: <5760595F.4040502@osg.samsung.com> Date: Tue, 14 Jun 2016 13:22:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2016 01:15 PM, Yannick Brosseau wrote: > On 06/14/2016 12:09 PM, Shuah Khan wrote: >> On 06/14/2016 12:45 PM, Yannick Brosseau wrote: >>> When running the execveat test once installed, the Makefile it not available and the >>> test fail. Bundling the Makefile file with the installed files fix that. >> Install is for installing kselftest binaries and run-time dependencies >> if any on a target system. It is not for being able to build it on the >> target. Bundling Makefile doesn't make sense. > The test tries to exec the Makefile file: > fail += check_execveat_fail(dot_dfd, "Makefile", 0, EACCES); > > So it's a runtime dependency at the moment. > We can either change the test to try to open another file or add the > Makefile Ah I see why Makefile is necessary. No point in adding a new file. Please add a comment in the file to indicate that Makefile is a run-time dependency. Could you also rephrase the change log to make it clear that Makefile is run-time dependency. Thanks for catching it. -- Shuah