From: Florian Fainelli <f.fainelli@gmail.com>
To: Shrikrishna Khare <skhare@vmware.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
pv-drivers@vmware.com
Subject: Re: [PATCH net-next v4 0/7] vmxnet3: upgrade to version 3
Date: Tue, 14 Jun 2016 13:22:02 -0700 [thread overview]
Message-ID: <5760676A.7070103@gmail.com> (raw)
In-Reply-To: <1465930348-92164-1-git-send-email-skhare@vmware.com>
On 06/14/2016 11:52 AM, Shrikrishna Khare wrote:
> This patchset upgrades vmxnet3 to version 3.
>
> Changes in v2:
> - Following patch is updated. See that patch for details:
> vmxnet3: add support for get_coalesce, set_coalesce ethtool
>
> Changes in v3:
> - fix subject line to use vmxnet3: instead of Driver:Vmxnet3
> - resubmit when net-next is open
>
> Changes in v4:
> - Following patch is updated. See that patch for details:
> vmxnet3: add support for get_coalesce, set_coalesce ethtool
You really need to improve your commit messages, because right now they
are inexistent or too obvious to be of any value. A reviewer must be
introduced to what code changes he/she is going to review next by
looking at the diff and whether this will match or not the description
that was provided in the commit message.
--
Florian
prev parent reply other threads:[~2016-06-14 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 18:52 [PATCH net-next v4 0/7] vmxnet3: upgrade to version 3 Shrikrishna Khare
2016-06-14 18:52 ` [PATCH net-next v4 1/7] vmxnet3: prepare for version 3 changes Shrikrishna Khare
2016-06-14 18:52 ` [PATCH net-next v4 2/7] vmxnet3: introduce generic command interface to configure the device Shrikrishna Khare
2016-06-14 18:52 ` [PATCH net-next v4 3/7] vmxnet3: allow variable length transmit data ring buffer Shrikrishna Khare
2016-06-14 18:52 ` [PATCH net-next v4 4/7] vmxnet3: add receive data ring support Shrikrishna Khare
2016-06-14 18:52 ` [PATCH net-next v4 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations Shrikrishna Khare
2016-06-14 19:38 ` Ben Hutchings
2016-06-14 18:52 ` [PATCH net-next v4 6/7] vmxnet3: introduce command to register memory region Shrikrishna Khare
2016-06-14 18:52 ` [PATCH net-next v4 7/7] vmxnet3: update to version 3 Shrikrishna Khare
2016-06-14 20:22 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5760676A.7070103@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).