From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932226AbcFOB40 (ORCPT ); Tue, 14 Jun 2016 21:56:26 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:47137 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbcFOB4Y (ORCPT ); Tue, 14 Jun 2016 21:56:24 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <0951047c2874aba3c64b417452be2f28> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support To: Doug Anderson References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <1465904780-935-1-git-send-email-ykk@rock-chips.com> Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Javier Martinez Canillas , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Tomasz Figa , David Airlie , Daniel Vetter , Thierry Reding , Krzysztof Kozlowski , Emil Velikov , Dan Carpenter , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , linux-samsung-soc , "open list:ARM/Rockchip SoC..." From: Yakir Yang Message-ID: <5760B5BE.8020908@rock-chips.com> Date: Wed, 15 Jun 2016 09:56:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Doug, On 06/14/2016 11:24 PM, Doug Anderson wrote: > Yakir, > > On Tue, Jun 14, 2016 at 4:46 AM, Yakir Yang wrote: >> RK3399 and RK3288 shared the same eDP IP controller, only some light >> difference with VOP configure and GRF configure. >> >> Signed-off-by: Yakir Yang >> Acked-by: Mark Yao >> --- >> Changes in v3: >> - Give the "rk3399-edp" a separate line for clarity in document (Tomasz, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346314/10/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt@5] >> - Move 'output_type' setting before the return statement (Tomasz, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346314/10/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@154] >> - Add the acked flag from Mark. >> >> Changes in v2: >> - rebase with drm-next, fix some conflicts >> >> .../bindings/display/bridge/analogix_dp.txt | 1 + >> .../display/rockchip/analogix_dp-rockchip.txt | 3 +- >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 33 +++++++++++++++++++++- >> include/drm/bridge/analogix_dp.h | 1 + >> 4 files changed, 36 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> index 4f2ba8c..4a0f4f7 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> @@ -5,6 +5,7 @@ Required properties for dp-controller: >> platform specific such as: >> * "samsung,exynos5-dp" >> * "rockchip,rk3288-dp" >> + * "rockchip,rk3399-edp" >> -reg: >> physical base address of the controller and length >> of memory mapped region. >> diff --git a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> index e832ff9..726c945 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> +++ b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> @@ -2,7 +2,8 @@ Rockchip RK3288 specific extensions to the Analogix Display Port >> ================================ >> >> Required properties: >> -- compatible: "rockchip,rk3288-edp"; >> +- compatible: "rockchip,rk3288-edp", >> + "rockchip,rk3399-edp"; > As commented by Tomasz on gerrit, there is a pre-existing typo here. > Specifically "rockchip,rk3288-edp" should be "rockchip,rk3288-dp". > > The typo is pre-existing so I'm not sure you would need to spin this > series to fix it, but if you were spinning it anyway it wouldn't hurt > to fix. Could also just send out a followon patch to fix this after > the series lands... My bad, forget to fix that :( it would be better to merge that fix into this series, would send a follow patch soon. Thanks for reminding, - Yakir > -Doug > > >