From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932319AbcFOB6r (ORCPT ); Tue, 14 Jun 2016 21:58:47 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:59012 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752776AbcFOB6p (ORCPT ); Tue, 14 Jun 2016 21:58:45 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 07/10] drm/bridge: analogix_dp: passing the connector as an argument in .get_modes() References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <1465904789-1021-1-git-send-email-ykk@rock-chips.com> <20160614162656.GA1338@phenom.ffwll.local> <20160614162849.GB1338@phenom.ffwll.local> Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Javier Martinez Canillas , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Tomasz Figa , David Airlie , Thierry Reding , dianders@chromium.org, Krzysztof Kozlowski , emil.l.velikov@gmail.com, Dan Carpenter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org To: daniel@ffwll.ch From: Yakir Yang Message-ID: <5760B648.7090709@rock-chips.com> Date: Wed, 15 Jun 2016 09:58:32 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160614162849.GB1338@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/2016 12:28 AM, Daniel Vetter wrote: > On Tue, Jun 14, 2016 at 06:26:56PM +0200, Daniel Vetter wrote: >> On Tue, Jun 14, 2016 at 07:46:29PM +0800, Yakir Yang wrote: >>> It's better to pass the connector to platform driver in .get_modes() >>> callback, just like what the .get_modes() helper function designed. >>> >>> Signed-off-by: Yakir Yang >> Also please drop the analogix prefix from the subject, this is for all >> drm_bridge drivers. > Ok, strike all my comments, I was blind and didn't realize that this was a > private interface for only rockchip/exynos. :) > -Daniel > >> -Daniel >> >>> --- >>> Changes in v3: >>> - Avoid to change any internal driver state in .mode_valid interface. (Tomasz, reviewed at Google Gerrit) >>> [https://chromium-review.googlesource.com/#/c/346318/10/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@113] >>> >>> Changes in v2: None >>> >>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +- >>> drivers/gpu/drm/exynos/exynos_dp.c | 4 ++-- >>> include/drm/bridge/analogix_dp.h | 3 ++- >>> 3 files changed, 5 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >>> index 4a1b3b8..1a890fa 100644 >>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >>> @@ -938,7 +938,7 @@ int analogix_dp_get_modes(struct drm_connector *connector) >>> num_modes += drm_panel_get_modes(dp->plat_data->panel); >>> >>> if (dp->plat_data->get_modes) >>> - num_modes += dp->plat_data->get_modes(dp->plat_data); >>> + num_modes += dp->plat_data->get_modes(dp->plat_data, connector); >>> >>> return num_modes; >>> } >>> diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c >>> index 468498e..8a555ed 100644 >>> --- a/drivers/gpu/drm/exynos/exynos_dp.c >>> +++ b/drivers/gpu/drm/exynos/exynos_dp.c >>> @@ -67,10 +67,10 @@ static int exynos_dp_poweroff(struct analogix_dp_plat_data *plat_data) >>> return exynos_dp_crtc_clock_enable(plat_data, false); >>> } >>> >>> -static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data) >>> +static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data, >>> + struct drm_connector *connector) >>> { >>> struct exynos_dp_device *dp = to_dp(plat_data); >>> - struct drm_connector *connector = &dp->connector; >>> struct drm_display_mode *mode; >>> int num_modes = 0; >>> >>> diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix_dp.h >>> index 82b8135..181db09 100644 >>> --- a/include/drm/bridge/analogix_dp.h >>> +++ b/include/drm/bridge/analogix_dp.h >>> @@ -34,7 +34,8 @@ struct analogix_dp_plat_data { >>> int (*power_off)(struct analogix_dp_plat_data *); >>> int (*attach)(struct analogix_dp_plat_data *, struct drm_bridge *, >>> struct drm_connector *); >>> - int (*get_modes)(struct analogix_dp_plat_data *); >>> + int (*get_modes)(struct analogix_dp_plat_data *, >>> + struct drm_connector *); >>> }; >>> >>> int analogix_dp_resume(struct device *dev); >>> -- >>> 1.9.1 >>> >>> >> -- >> Daniel Vetter >> Software Engineer, Intel Corporation >> http://blog.ffwll.ch