From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753294AbcFOHyZ (ORCPT ); Wed, 15 Jun 2016 03:54:25 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:35088 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbcFOHyX convert rfc822-to-8bit (ORCPT ); Wed, 15 Jun 2016 03:54:23 -0400 X-AuditID: cbfee690-f79056d000001327-74-576109aa67eb MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <576109AA.8020601@samsung.com> Date: Wed, 15 Jun 2016 16:54:18 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Roger Quadros , myungjoo.ham@samsung.com Cc: balbi@kernel.org, nm@ti.com, grygorii.strashko@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection References: <1465913075-30166-1-git-send-email-rogerq@ti.com> <5760B604.10407@samsung.com> <5760FA16.5070008@ti.com> In-reply-to: <5760FA16.5070008@ti.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWyRsSkQHcVZ2K4weJOA4tjbU/YLVZOYbG4 vGsOm8XsJf0sFrcbV7BZvPlxlsmi55GWA7vHplWdbB59W1Yxehy/sZ3J4/MmuQCWKC6blNSc zLLUIn27BK6M2U/usRXs56tY+HkvUwPjF+4uRk4OCQETiccbnjBB2GISF+6tZ+ti5OIQEljB KHG3ZRszTFF/wzFGiMQsRolb76cygiR4BQQlfky+x9LFyMHBLKAuMWVKLkiYWUBE4uLCCUwQ trbEsoWvmSF6HzBKXOltherVkti8Yy6YzSKgKrF12y1WEJsNKL7/xQ02kJmiAhES3ScqQUwR AWuJDd99IDaVSvS2hoMUCwtESRxa9wXq5DOMEqc2/mIBSXAKqEl8WTkTLCEhsI9dYu72d2wQ qwQkvk0+BHayhICsxKYDUC9KShxccYNlAqP4LCSPzUJ4bBaSx2YheWwBI8sqRtHUguSC4qT0 IhO94sTc4tK8dL3k/NxNjMCYPP3v2YQdjPcOWB9iFOBgVOLh5ahJCBdiTSwrrsw9xGgKdNBE ZinR5Hxg5OeVxBsamxlZmJqYGhuZW5opifO+lvoZLCSQnliSmp2aWpBaFF9UmpNafIiRiYNT qoHR6tPuZ2d2p15da3ZfdGdSzYX710ymfxKY9miFSNc6iawpBbMF7v/I2fb+/8F9kv9t2afW GrzaZ1M/R8LkwsqDH3vPLHh0WGpi5oKSuLe9VRfUVxQeNmsu2h/qfqRAe/vkzU/sUi4a/xef 9t8/IVJbL+DHmR2i926/Wamo83Dn1Yzq6b8djn0KcFViKc5INNRiLipOBACJboXsxAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsVy+t9jQd1VnInhBo2rtCyOtT1ht1g5hcXi 8q45bBazl/SzWNxuXMFm8ebHWSaLnkdaDuwem1Z1snn0bVnF6HH8xnYmj8+b5AJYohoYbTJS E1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOADlBSKEvMKQUK BSQWFyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYwZuyfsoi1YDZfxcdfR5kaGC9wdzFyckgI mEj0NxxjhLDFJC7cW8/WxcjFISQwi1Hi1vupYAleAUGJH5PvsXQxcnAwC8hLHLmUDWGqS0yZ kgtR/oBR4kpvK1S5lsTmHXPBbBYBVYmt226xgthsQPH9L26wgfSKCkRIdJ+oBDFFBKwlNnz3 gZhYKtHbGg5SLCwQJXFo3ReoY84wSpza+IsFJMEpoCbxZeVMtgmMQCci3DYL4bZZCLctYGRe xSiRWpBcUJyUnmuYl1quV5yYW1yal66XnJ+7iREcw8+kdjAe3OV+iFGAg1GJh7fAMSFciDWx rLgy9xCjBAezkgivB2tiuBBvSmJlVWpRfnxRaU5q8SFGU6DnJjJLiSbnA9NLXkm8obGJmZGl kbmhhZGxuZI47+P/68KEBNITS1KzU1MLUotg+pg4OKUaGM/6urY8n/5PuiLPaPKOpaw/G9v3 Xd/MecdBujH3+SaBdS6s4Wl+wi0FSe6q54pnaFndj5nBXLb5YdjNrZMadJ89/R77ppq5STXt aMjPmpBZzGvclp7n66tw49guYJPMdNl9qt9UxUY5BtZD+WzTNC1OzdiivERwu6t13IOIJccu RGbvda+IUWIpzkg01GIuKk4EADLGvsj3AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 06월 15일 15:47, Roger Quadros wrote: > On 15/06/16 04:57, Chanwoo Choi wrote: >> On 2016년 06월 14일 23:04, Roger Quadros wrote: >>> If USB cable is connected prior to boot, we don't get any interrupts >>> so we must manually check the VBUS state and report it during probe. >>> If we don't do it then USB controller will never know that peripheral >>> cable was connected till the user unplugs and replugs the cable. >>> >>> Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO") >>> Signed-off-by: Roger Quadros >>> --- >>> drivers/extcon/extcon-palmas.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c >>> index 8b3226d..caff46c 100644 >>> --- a/drivers/extcon/extcon-palmas.c >>> +++ b/drivers/extcon/extcon-palmas.c >>> @@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev) >>> >>> palmas_enable_irq(palmas_usb); >>> /* perform initial detection */ >>> + if (palmas_usb->enable_gpio_vbus_detection) >>> + palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb); >>> palmas_gpio_id_detect(&palmas_usb->wq_detectid.work); >>> device_set_wakeup_capable(&pdev->dev, true); >>> return 0; >>> >> >> Applied it. > > Thanks. But this is a bug fix and must go in v4.7-rc > as well as stable v4.6+. OK. I'll send the pull request for this patch. > > Can you please add > > Cc: stable@vger.kernel.org # v4.6+ If we should add the 'stable@verger.kernel.org', this patch should be sent to mailing list. So, I think that you better to send this patch including stable mailing list. And then, I'll send pull request which apply this patch to 4.7-rc. Thanks, Chanwoo Choi