From: Randy Dunlap <rdunlap@infradead.org>
To: Andreas Ziegler <andreas.ziegler@fau.de>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: select on non-existing Kconfig option CRC32C
Date: Wed, 15 Jun 2016 07:40:37 -0700 [thread overview]
Message-ID: <576168E5.9020009@infradead.org> (raw)
In-Reply-To: <5761275B.4010508@fau.de>
On 06/15/16 03:00, Andreas Ziegler wrote:
> Hi Hendrik,
>
> your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
> algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195.
>
> The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C.
> However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist.
> Should I prepare a trivial patch to fix this up or would you like to do that on
> your side?
>
> I found this issue by comparing yesterday's tree and today's tree using
> 'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'.
or should it select CRC32 or LIBCRC32C? (probably not the LIB... one)
--
~Randy
next prev parent reply other threads:[~2016-06-15 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 10:00 select on non-existing Kconfig option CRC32C Andreas Ziegler
2016-06-15 14:40 ` Randy Dunlap [this message]
2016-06-15 14:41 ` Hendrik Brueckner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576168E5.9020009@infradead.org \
--to=rdunlap@infradead.org \
--cc=andreas.ziegler@fau.de \
--cc=brueckner@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).