From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933447AbcFOPtD (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 11:49:03 -0400
Received: from bear.ext.ti.com ([198.47.19.11]:40869 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933313AbcFOPs6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 11:48:58 -0400
Subject: Re: [PATCH v3 0/2] Add support for SYSCON reset
To: Philipp Zabel <p.zabel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Suman Anna <s-anna@ti.com>
References: <20160601184125.20241-1-afd@ti.com>
CC: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: "Andrew F. Davis" <afd@ti.com>
Message-ID: <576178C7.4040204@ti.com>
Date: Wed, 15 Jun 2016 10:48:23 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160601184125.20241-1-afd@ti.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/01/2016 01:41 PM, Andrew F. Davis wrote:
> Some SoCs contain reset controls for modules that are memory-mapped to
> areas shared with other module configuration settings. This requires
> synchronization across all drivers accessing this memory area. This
> series adds a generic SYSCON reset driver to allow resets toggled
> by bits in memory-mapped registers through SYSCON.
> 
> Changes from v2:
>  - Rebased on v4.7-rc1
>  - Removed the need to give reset specifier nodes an index address
> 
> Changes from v1:
>  - Reset control information is now described in the reset node, this
>    keeps the reset information centralized for easy verification
>  - Other small fixups
> 
> Andrew F. Davis (2):
>   Documentation: dt: reset: Add syscon reset binding
>   reset: add a SYSCON based reset driver
> 
>  .../devicetree/bindings/reset/syscon-reset.txt     | 105 ++++++++
>  drivers/reset/Kconfig                              |  10 +
>  drivers/reset/Makefile                             |   1 +
>  drivers/reset/reset-syscon.c                       | 289 +++++++++++++++++++++
>  include/dt-bindings/reset/syscon.h                 |  23 ++
>  5 files changed, 428 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reset/syscon-reset.txt
>  create mode 100644 drivers/reset/reset-syscon.c
>  create mode 100644 include/dt-bindings/reset/syscon.h
> 

Is there any additional feedback for this driver? I normally try to
refrain from pings, but this may begin to block further upstreaming of
IPs that uses this reset if it can not be taken this cycle.

If there is still an objection to calling this a generic reset solution
we would not strongly object to relabeling this to something implying
more TI exclusivity.

Thanks,
Andrew