From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933181AbcFOTVj (ORCPT ); Wed, 15 Jun 2016 15:21:39 -0400 Received: from mail-by2on0132.outbound.protection.outlook.com ([207.46.100.132]:39005 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933133AbcFOTV3 (ORCPT ); Wed, 15 Jun 2016 15:21:29 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <5761AAA9.1080406@hpe.com> Date: Wed, 15 Jun 2016 15:21:13 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Peter Zijlstra CC: Ingo Molnar , , , , , , , Davidlohr Bueso , Jason Low , Dave Chinner , Scott J Norton , Douglas Hatch Subject: Re: [RFC PATCH-tip v2 4/6] locking/rwsem: move down rwsem_down_read_failed function References: <1465944489-43440-1-git-send-email-Waiman.Long@hpe.com> <1465944489-43440-5-git-send-email-Waiman.Long@hpe.com> <20160615174055.GS30921@twins.programming.kicks-ass.net> In-Reply-To: <20160615174055.GS30921@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [71.168.64.62] X-ClientProxiedBy: BLUPR01CA062.prod.exchangelabs.com (10.160.23.52) To TU4PR84MB0319.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.29) X-MS-Office365-Filtering-Correlation-Id: 23d84b7e-e2c9-4dfc-3613-08d395523efb X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0319;2:G2vWMJFdJSgnNFc8DywykReVyy/H+LsuyWz0BH/kdXhfLNniTL2cX9clGpgiF4YVvJZ80ZNS+wqKAqpvgBl8JrbRFoYpXI+T8a4GEyDJkwNhUwjng7Wcu9EWjxBHs5j8ycZ/r9/Rgg/8O6VQ54SmWw8Vivf0+7cjqzLNcdgVFRzYqQKc1tgRLJTl6nIHVj+5;3:+Ygm801T7gNNdy1fM35FU1tK6pAUbbyxMD8v1lnE5Tn8EYMwiodQhmSuWeWNsLubsi+fAdsygWHOm+0W1s3t/Qv5QFJ6v1PCQFk975IRj0/4SzsmpVGM3lfCpTcuxG7S;25:pvjVH1vNVGhdeYsG/sAkBpMv+V9LTQxTNWf7IfhLT9pfV5t9lT6i6KfdmnDrjhrUlx+aoSYvcSdyfqcLMqcTElQxuQrZ4tIs0htFfuaOs+djjqG9wTueeusXNzlAX36mL+KJk3xSUaknT57V4kYeTrx296CYYSasN+q/JHl40M9v+ZkR539yZRcxD+2bfzeD0ZnsJ7DBz/sUdoQq+i1cL4F/vgtUq4QlCpyuRAfwc2Zck5Z2it9BHVBbo0QBoJk0ZQWV+Fo9vehi/JJw7x5g4dEbwm2H/OR6PhlzmwYImz+Mfw9kHElHtZrMAxHu81ZEpysZDG77UgNJR56/fjtRfED0daYcIW1LFuLTfkaEezluDjZ8Ih6LEoDOwykX47PYto6bkQseK9Mu6lbUIZlz9h3//KHSOG1wKehPFSYJVx0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0319; X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0319;20:wfeovQ9O+J4dCID2a9ZgWBBK5zKb5udR76PMP+oQFhggx2WWUU4oRZ8IjhasXZ+AUiiXLHSNBEARQRaq6z85mz1Zr+VDV9b/uDwf/h6qHI1u3dNdCl1HOgSYksJO1hiwRXKbribE4qXdxlCBb+Wx/9geBWZKwIp1rONTqdJBvI0tw5uYd7o/BMWyA5sjzIoFkpGbAPrJ8qIJ0/mcvd6mLIBfmqjYdBre0biFZjouHw7xoY5WwDDO9ppqpZU8CFVXNpWRicNl1Epzse9kVooIbX0dTvcKy5J7XHcZoBxjga7u/PFLRiAD+S9xHha/UYbt7B496GgxiQ9XGGaErxiXx6nz6yGCNUXXwe8qo7O8xM5tFhbfq8Gt0OuO6Lq5V+ixGe5Ns1aIbMZeX+VFXdk8B5/Q1W/0c72dCJj4qs8tenJbkind6v0HhpQxbwX9uos2tk/6R+CszvUtiuykQbKEuqVDH45JHxXT+UfC/3yVHqjK0dOoS3+5uH3hgk9x4Z8b;4:ksP1frTOBhO1hxGpe6jDZTA29g1I4zGOSaySGKkDnIjmrfY5mnRcZmbHqsL/wsRH2v23Pmn5KZl5aLAuGo9jomN+c/44Td/ZeK8uXoGf2qUuHkiHoBZbTsjoeWCNQx7JdeczJPUN3oHIbm5RiStwYZk3Gkqtk7INOVkO/QnJPUr+0E/BSPgxIdduVKMuuPc54OHqd2ZY1Lx3AJPDDvYz+/y1m77h35TkpgSZF8Zx8tZOzcLLlxkVBs/zvx+BAig5BIhdAL6IgQARk2qiOtdg936rZX6vr8lfNPGICDt1amHoGfgBm8qhemTJg8BblK09wCJxi2LYOWVLQnDnNwjwm1LeDGwaO3/sn3dMSw7422TcSr2Ow9QHEv1a0M1XWhO6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:TU4PR84MB0319;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0319; X-Forefront-PRVS: 09749A275C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(189002)(199003)(24454002)(54534003)(101416001)(2950100001)(50466002)(65816999)(6116002)(2906002)(8676002)(5004730100002)(81166006)(8666005)(4326007)(5008740100001)(97736004)(33656002)(23756003)(68736007)(3846002)(4001350100001)(81156014)(77096005)(80316001)(47776003)(230700001)(117156001)(59896002)(106356001)(87266999)(54356999)(76176999)(50986999)(83506001)(105586002)(189998001)(86362001)(65806001)(42186005)(586003)(92566002)(65956001)(110136002)(64126003)(66066001)(36756003)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR84MB0319;H:[192.168.142.154];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;TU4PR84MB0319;23:QYVGJFK8mvuzawI9/uc4NKlNHO5cFtjxPeD1ImF?= =?iso-8859-1?Q?MsMigZHyIlUCN+tAmd3KCZ79TzNfhiSc5is2IdV69T8Sp4W6rxc+19UReC?= =?iso-8859-1?Q?E4pm3VLEbpVIbgMAo4El2uX/kp6PiWzfbEk7TYhS1WZbn4YEFxO4XzAOrU?= =?iso-8859-1?Q?tI3CFnAa1O9KblC5cbwXH5oecd8p/j1jMNqr75FtzIrXt2Dl4SkaA8ggXe?= =?iso-8859-1?Q?WlZprzg7WesUDP4N0tLHX99h/NrdlxyIPYNPA5OnHHVw+MIaFn7wT4sYo1?= =?iso-8859-1?Q?KaCbY64SNmCeJAr4COVk3884iHYzo9HvS+czbEgscNvPvDUtrn5Puu/ga8?= =?iso-8859-1?Q?+2G5R44P8g+DRWRWzzw0zMRU0WnoEF+iESCkkE5V+02JQiphJhwXVLqqNw?= =?iso-8859-1?Q?XrTnGKFvuh3wHsfLp7edOD4LXU72puTgLkXTDzWHMuLAgodfO8gGseMllv?= =?iso-8859-1?Q?RqZFddvYJwUPvE6huR69cgCiscYTEncqD/asvaQDVoa2XGmDBFL72d0otL?= =?iso-8859-1?Q?+SWv3jrbzcfmYIgNFR92LzOIvhLi0LZkRL+R1pdm8EHshTStPOuG06c9kH?= =?iso-8859-1?Q?RdIdXg6SMzPZIB+p9qzcK1IJMlF7V6lM2fiUmQmsKsVY3nDZMnCYSCAKA7?= =?iso-8859-1?Q?ARGY5Cu4ks8anpaqVmz7uxp7Y1yjhiV/jUT/y3mhW05Fa5jV3YPS/6EVyi?= =?iso-8859-1?Q?cPgZWaAYwTf68r/miwM+SYUYjZ0W47YAaOUkr67UpYToN1AsnvFMtJRiPB?= =?iso-8859-1?Q?WjWEhmlKV8GKos7i7tcSzrdXee6wy2ZtYXEQIAhFlWRRtbSDK482+9GFu2?= =?iso-8859-1?Q?MdeGPweaAoorIUAFzsIH849gi5GemVDJjTAQ+97+yJlXYeJPgg4wTTGSDr?= =?iso-8859-1?Q?e7CHeVJcmMHHEgXHd+1p/iDMRQ/R8CUDwDlorBO7W6BdqoFez/mhOFibRg?= =?iso-8859-1?Q?Nfwuwep7Jyl4TzryGdIhXiBLId3Ax0lL9DRK/zVxukxXVhMZ9I/84bDB0+?= =?iso-8859-1?Q?9kPTREGyFfUhYHibBjlFd4nmrmLmLvXYc/UR/WhI8U20PqNwozjUesUb2e?= =?iso-8859-1?Q?q6/tgsMRUZx5w30B7SPDCqET1fHgCVOCh1DIBmaRsA3HvmAji6771Jq8zt?= =?iso-8859-1?Q?Oc/7cmItjB7i3WICRYXSEob1VzQ8Rc4AVmRqXeEKkD1AAn8fiqe3JOZP1q?= =?iso-8859-1?Q?tXOY09Uk+YFffkoAyewEKcIGICIwggtxJBI6h9qM23lsIBspclNRdcX5LX?= =?iso-8859-1?Q?cZrwfjcR88KV/nyUB5FGbpdPp4C+Au6XeMcj1RGj+QSW8hHo16UEC0HqXO?= =?iso-8859-1?Q?pQE7pfZTQC1FgQ16zLJ+Kxp1D1D0j+nUu3EksI4cwDSsU9sgs4moRAb08y?= =?iso-8859-1?Q?xDrXrp1Q=3D?= X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0319;6:XHDeTlXG8Am7KriE4LXX3h4atzZ4e7tj+y0LVrHNMwetk7JQPE5onDCZxrf3s8l7urznEF/Ps6u1qPpRk54FfBCDMGfJAav7TsC/Wb9ZwShpOiUfOScpYL6lF6xa0MziYOWVBLFTl2EBYKwKY34bqF6sukyl5iPxE9C+qaJK2+sMy+rMpYI/hJQNfSW9bUC7FHmdI1e8ODsOo16hiTSUuoOHoilJrIZ6JKizZOnUkM+kNNIrlgF0do00L5isEIZV0J5DE3+DqntmvC9UXuwK6Hg/Upbv0zNgM0tBUdejMXA=;5:lAqpw2Vi7jsXAEXPhNLJpAtSPhF1qB9uUwIlaqOIn6M8wJpXyaq8EMMPQRLSgWYie5XFidZ24RjjPiD0h9E+MNka6saUYBAfogOIAosoXk1oVHOpja0ra7AJVdENGu7Z3ljQzrwfmbSJwQCz0k42zg==;24:JJHegL5+/D9Wb/BTi5DmmGhyezg3+LsHobRgMPkQvlYuSJmd/zUaPkBWeN5taHoamAWUVCL9QX9OsQNv1/mrGMjFIU22WBA5ihBW8mln6uo=;7:VuKYSAr0rGL050uevlpbwX+BsaTLqXTOsIV5e9Q6nfiT1VS2NKs2r8Z4bYDeJIrqaZvoOSj+SGxDzYVM3iCyCYdhjizk1SF754CsJtrjhuM3Y3q1gGa7PtZnOT+FBA7op6MNY75CULQfDgBcOyhaJADObpEisafyOoDOp9cg7n16oSHf0Lk3JyFfjuadTafDaT94B8Q2qiRUaFqjyanMb1cU6F/FVnYrKL6XRilhFvA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2016 19:21:23.1498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0319 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/2016 01:40 PM, Peter Zijlstra wrote: > On Tue, Jun 14, 2016 at 06:48:07PM -0400, Waiman Long wrote: >> Move the rwsem_down_read_failed() function down to below the optimistic >> spinning section before enabling optimistic spinning for the readers. > newline > >> There is no change in code. > Changelog fails to explain the why part. Thanks for pointing this out. I will update the changelog to mention that the movement is needed because it is going to call rwsem_optimistic_spin() in later patch. Cheers, Longman