From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Rob Herring <robh@kernel.org>, Sakari Ailus <sakari.ailus@iki.fi>
Cc: "Sebastian Reichel" <sre@kernel.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] media: et8ek8: Add documentation
Date: Wed, 15 Jun 2016 22:24:40 +0300 [thread overview]
Message-ID: <5761AB78.2030707@gmail.com> (raw)
In-Reply-To: <CAL_JsqKDxnc-pTOcdbL4iWFB9qU5924N0TV0NFw=A-zGN8boXQ@mail.gmail.com>
On 15.06.2016 21:41, Rob Herring wrote:
> On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
>> Hi Rob,
>>
>> On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote:
>>> On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote:
>>>> Add DT bindings description
>>>
>>> Not exactly the best commit msg.
>>>
will elaborate a bit more in the next patch version
>>>>
>>>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>>>> ---
>>>> .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++
>>>> 1 file changed, 50 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
>>>> new file mode 100644
>>>> index 0000000..997d268
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
>>>> @@ -0,0 +1,50 @@
>>>> +Toshiba et8ek8 5MP sensor
>>>> +
>>>> +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
>>>> +
>>>> +More detailed documentation can be found in
>>>> +Documentation/devicetree/bindings/media/video-interfaces.txt .
>>>> +
>>>> +
>>>> +Mandatory properties
>>>> +--------------------
>>>> +
>>>> +- compatible: "toshiba,et8ek8"
>>>> +- reg: I2C address (0x3e, or an alternative address)
>>>> +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
>>>
>>>> +- clocks: External clock to the sensor
>>>> +- clock-frequency: Frequency of the external clock to the sensor
>>>
>>> These should be mutually-exclusive. If you have a clock, then you can
>>> get the frequency at runtime.
>>
>> Yes, you can. But the intention is to set the frequency: the sensor requires
>> a particular, pre-determined frequency. Typically this is specific to the
>> board.
>
> Okay, then state that in the description.
>
ok, will do in the next patch version
Thanks,
Ivo
next prev parent reply other threads:[~2016-06-15 19:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 15:39 [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Ivaylo Dimitrov
2016-06-11 15:39 ` [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor Ivaylo Dimitrov
2016-06-18 15:22 ` Pavel Machek
2016-06-18 15:37 ` Pali Rohár
2016-06-18 16:04 ` Pavel Machek
2016-06-18 16:11 ` Pali Rohár
2016-06-20 21:59 ` Sakari Ailus
2016-06-11 15:39 ` [PATCH v3 2/2] media: et8ek8: Add documentation Ivaylo Dimitrov
2016-06-14 22:05 ` Rob Herring
2016-06-15 4:31 ` Sakari Ailus
2016-06-15 18:41 ` Rob Herring
2016-06-15 19:24 ` Ivaylo Dimitrov [this message]
2016-06-18 14:36 ` Pavel Machek
2016-10-23 7:33 ` [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Pavel Machek
2016-10-23 10:22 ` v4.9-rc1: smiapp divides by zero Pavel Machek
2016-10-23 10:32 ` Pali Rohár
2016-10-23 10:52 ` Pavel Machek
2016-10-23 14:09 ` Sakari Ailus
2016-10-23 18:33 ` Pavel Machek
2016-10-23 18:05 ` [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Ivaylo Dimitrov
2016-10-23 18:17 ` Pavel Machek
2016-10-23 18:36 ` Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5761AB78.2030707@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).