From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753829AbcFPGfV (ORCPT ); Thu, 16 Jun 2016 02:35:21 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:10109 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbcFPGfS (ORCPT ); Thu, 16 Jun 2016 02:35:18 -0400 X-AuditID: cbfec7f5-f792a6d000001302-44-576248a31675 Subject: Re: [PATCH v2 1/4] max8903: adds documentation for device tree bindings. To: chris@lapa.com.au References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1465561970-18377-1-git-send-email-chris@lapa.com.au> <1465561970-18377-2-git-send-email-chris@lapa.com.au> <575AC5E5.3020405@samsung.com> <001abdba-d10c-90d5-944f-ebeaf236eb12@lapa.com.au> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <576248A2.3030004@samsung.com> Date: Thu, 16 Jun 2016 08:35:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <001abdba-d10c-90d5-944f-ebeaf236eb12@lapa.com.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrELMWRmVeSWpSXmKPExsVy+t/xa7qLPZLCDf6uErB4eMbMYv6Rc6wW r18YWlzeNYfN4nPvEUYHVo9lczczevRtWcXo8XmTXABzFJdNSmpOZllqkb5dAlfGtX9NbAXv ZCrmHLzK0sDYJt7FyMkhIWAiMfHrDXYIW0ziwr31bCC2kMBSRonL/yIg7GeMEnsbw0FsYYFg iRdPljOB2CICohI//25mh6hpZ5JY/TQNxGYWiJDofHAILM4mYCyxefkSsJm8AloS73qWMYLY LAKqEo137rGC2KJA9bO2/2CCqBGU+DH5HguIzSlgL/Hs3wugGg6gmXoS9y9qQYyXl9i85i3z BEaBWUg6ZiFUzUJStYCReRWjaGppckFxUnqukV5xYm5xaV66XnJ+7iZGSMh+3cG49JjVIUYB DkYlHl6B9YnhQqyJZcWVuYcYJTiYlUR4H9gnhQvxpiRWVqUW5ccXleakFh9ilOZgURLnnbnr fYiQQHpiSWp2ampBahFMlomDU6qBUXDx5ptTtq89tD4zacpCmwUvN704f89NuVZnd2hgd1Cl vLncasHF2awrLmSdWvSI/bp/h0Jk8ap680mKRw9fmJZfO6fm3x/9NfUrNmpmNGSmRvkbzG3b +PDv7vmCSxtTVKzistY98Xd/zT/P0TZEROg4/87f27RXLmT5zrP55fSck74iCvzVfEosxRmJ hlrMRcWJAM26NvpVAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2016 03:54 AM, Chris Lapa wrote: > On 10/06/2016 11:51 PM, Krzysztof Kozlowski wrote: >> On 06/10/2016 02:32 PM, Chris Lapa wrote: >>> From: Chris Lapa >>> >>> Signed-off-by: Chris Lapa >>> --- >>> .../devicetree/bindings/power/max8903-charger.txt | 30 >>> ++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/power/max8903-charger.txt >> >> You again skipped all of the maintainers. Your patch won't be applied. >> You need to send the patch to the appropriate person so he/she could >> apply it. >> >> From this patch: >> Rob Herring (maintainer:OPEN FIRMWARE AND FLATTENED >> DEVICE TREE BINDINGS,commit_signer:9/19=47%) >> Mark Rutland (maintainer:OPEN FIRMWARE AND >> FLATTENED DEVICE TREE BINDINGS) >> >> From power suppyy tree: >> Sebastian Reichel (maintainer:POWER SUPPLY >> CLASS/SUBSYSTEM and DRIVERS) >> Dmitry Eremin-Solenikov (maintainer:POWER SUPPLY >> CLASS/SUBSYSTEM and DRIVERS) >> David Woodhouse (maintainer:POWER SUPPLY >> CLASS/SUBSYSTEM and DRIVERS) >> >> >>> diff --git >>> a/Documentation/devicetree/bindings/power/max8903-charger.txt >>> b/Documentation/devicetree/bindings/power/max8903-charger.txt >>> new file mode 100644 >>> index 0000000..e0b5366 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt >>> @@ -0,0 +1,30 @@ >>> +Maxim Semiconductor MAX8903 Battery Charger bindings >>> + >>> +Required properties: >>> +- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger >>> +- dc_valid: Specifies that the DC portion of the MAX8903 has been >>> connected up >>> + and that dok-gpios should be specified >> >> You don't need the dc_valid nor the usb_valid. If the dok-gpios are >> present - use DC power. If the uok-gpios - USB power. >> > I did think that as well, but I didn't want to break backwards > compatibility. What do you mean by backwards compatibility? The driver did not support DeviceTree before so it is not about DT compatibility. If you think about platform data then it is different: how you match DT into driver's structure is up to you. > >> If both or none: print error. > Its valid to have both connected. Ah, okay. Just an example. > >> >> BTW, It would be nice if send also the user of this bindings - DTS/DTSI. > I'm not sure I understand what you mean here? I mean I would like to see the DTS file which is using this device and these bindings. It is not necessary but it would be nice. Best regards, Krzysztof > >> >> Best regards, >> Krzysztof >> >>> + - dok-gpios: Valid DC power has been detected >>> +- usb_valid: Specifies that the USB portion of the MAX8903 has been >>> connected up >>> + and that uok-gpios should be specified >>> + - uok-gpios: Valid USB power has been detected >>> + >>> +Optional properties: >>> +- cen-gpios: Charge enable pin >>> +- chg-gpios: Charger status pin >>> +- flt-gpios: Fault pin >>> +- dcm-gpios: Current limit mode setting (DC or USB) >>> +- usus-gpios: USB suspend pin >>> + >>> + >>> +Example: >>> + >>> + max8903-charger { >>> + compatible = "maxim,max8903-charger"; >>> + dok-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; >>> + flt-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; >>> + chg-gpios = <&gpio3 15 GPIO_ACTIVE_LOW>; >>> + cen-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; >>> + dc_valid; >>> + status = "okay"; >>> + }; >>> >> > > >