From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754590AbcFPNjr (ORCPT ); Thu, 16 Jun 2016 09:39:47 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:11611 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753861AbcFPNjp (ORCPT ); Thu, 16 Jun 2016 09:39:45 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: stefanb@linux.vnet.ibm.com X-IBM-RcptTo: peterhuewe@gmx.de;jarkko.sakkinen@linux.intel.com;tpmdd-devel@lists.sourceforge.net;jgunthorpe@obsidianresearch.com;tpmdd@selhorst.net;linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Subject: Re: [PATCH] tpm_vtpm_proxy: fix sparse warning To: Jarkko Sakkinen , Peter Huewe References: <1466073474-4381-1-git-send-email-jarkko.sakkinen@linux.intel.com> Cc: linux-security-module@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , "moderated list:TPM DEVICE DRIVER" , open list From: Stefan Berger Date: Thu, 16 Jun 2016 09:39:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1466073474-4381-1-git-send-email-jarkko.sakkinen@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061613-0008-0000-0000-000004D33F8E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061613-0009-0000-0000-00003871FBF8 Message-Id: <5762AC1A.8050702@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-16_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606160152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2016 06:37 AM, Jarkko Sakkinen wrote: > When running make C=2 M=drivers/char/tpm/ > > CC [M] drivers/char/tpm//tpm_crb.o > CHECK drivers/char/tpm//tpm_vtpm_proxy.c > drivers/char/tpm//tpm_vtpm_proxy.c:552:32: warning: incorrect type in assignment (different address spaces) > drivers/char/tpm//tpm_vtpm_proxy.c:552:32: expected struct vtpm_proxy_new_dev *vtpm_new_dev_p > drivers/char/tpm//tpm_vtpm_proxy.c:552:32: got void [noderef] *argp > drivers/char/tpm//tpm_vtpm_proxy.c:553:51: warning: incorrect type in argument 2 (different address spaces) > drivers/char/tpm//tpm_vtpm_proxy.c:553:51: expected void const [noderef] *from > drivers/char/tpm//tpm_vtpm_proxy.c:553:51: got struct vtpm_proxy_new_dev *vtpm_new_dev_p > drivers/char/tpm//tpm_vtpm_proxy.c:559:34: warning: incorrect type in argument 1 (different address spaces) > drivers/char/tpm//tpm_vtpm_proxy.c:559:34: expected void [noderef] *to > drivers/char/tpm//tpm_vtpm_proxy.c:559:34: got struct vtpm_proxy_new_dev *vtpm_new_dev_p > > The __user annotation was missing from the corresponding variable. > > Signed-off-by: Jarkko Sakkinen Tested-by: Stefan Berger PS: I get similar warnings for line 248 in tpm_crb.c.