From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robh@kernel.org>
Cc: green.hu@gmail.com, David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>,
devicetree@vger.kernel.org, andrew@lunn.ch, jiri@resnulli.us,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
f.fainelli@gmail.com, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v4] net: ethernet: faraday: To support device tree usage.
Date: Wed, 01 Feb 2017 16:47:20 +0100 [thread overview]
Message-ID: <5763539.ftMn9eb5Wh@wuerfel> (raw)
In-Reply-To: <20170127221733.tcoudehkp5b5jnfw@rob-hp-laptop>
On Friday, January 27, 2017 4:17:33 PM CET Rob Herring wrote:
> On Wed, Jan 25, 2017 at 10:09:20PM +0100, Arnd Bergmann wrote:
> > On Wed, Jan 25, 2017 at 6:34 PM, David Miller <davem@davemloft.net> wrote:
> > > From: Greentime Hu <green.hu@gmail.com>
> > > Date: Tue, 24 Jan 2017 16:46:14 +0800
> > >> We also use the same binding document to describe the same faraday ethernet
> > >> controller and add faraday to vendor-prefixes.txt.
> > >
> > > Why are you renaming the MOXA binding file instead of adding a completely new one
> > > for faraday? The MOXA one should stick around, I don't see a justification for
> > > removing it.
> >
> > This was my suggestion, basically fixing the name of the existing
> > binding, which was
> > accidentally named after one of the users rather than the company that did the
> > hardware.
> >
> > We can't change the compatible string, but I'd much prefer having only
> > one binding
> > file for this device rather than two separate ones that could possibly become
> > incompatible in case we add new properties to them. If there is only
> > one of them,
> > naming it according to the hardware design is the general policy.
> >
> > Note that we currently have two separate device drivers, but that is more a
> > historic artifact, and if we ever get around to merging them into one driver,
> > that should not impact the binding.
>
> The change is fine with me, but the subject and commit message need some
> work. I'm guessing faraday licensed this to MOXA or something?
Correct, Faraday just produces IP blocks.
> Why is the new name preferred or better?
The situation is similar to the designware "dwmac", which for historic
reasons is called "stmmac" in Linux, both for the binding and the driver
name. I think this should have been dwmac from the start, but changing
it earlier is much easier than changing it later.
Arnd
next prev parent reply other threads:[~2017-02-01 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 8:46 [PATCH v4] net: ethernet: faraday: To support device tree usage Greentime Hu
2017-01-25 17:34 ` David Miller
2017-01-25 21:09 ` Arnd Bergmann
2017-01-27 22:17 ` Rob Herring
2017-02-01 15:47 ` Arnd Bergmann [this message]
2017-02-08 11:59 ` Greentime Hu
2017-02-10 15:03 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2017-01-05 10:23 Greentime Hu
2017-01-05 21:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5763539.ftMn9eb5Wh@wuerfel \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=green.hu@gmail.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).