From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754793AbcFQGXk (ORCPT ); Fri, 17 Jun 2016 02:23:40 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:28294 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbcFQGXi (ORCPT ); Fri, 17 Jun 2016 02:23:38 -0400 X-AuditID: cbfec7f4-f796c6d000001486-68-57639767a6b5 Subject: Re: [PATCH v3 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm. To: Chris Lapa , dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1466139626-51434-1-git-send-email-chris@lapa.com.au> <1466139626-51434-4-git-send-email-chris@lapa.com.au> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <57639765.3030101@samsung.com> Date: Fri, 17 Jun 2016 08:23:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1466139626-51434-4-git-send-email-chris@lapa.com.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsVy+t/xq7rp05PDDRYd5rN4eMbMYtKT98wW 84+cY7WYuHIys8XrF4YWl3fNYbP43HuE0WLp9YtMFq17j7BbnN5d4sDlsWbeGkaPnbPusnts XqHlsWlVJ5vHsrmbGT36tqxi9Pi8SS6APYrLJiU1J7MstUjfLoEr4/HXKSwFr9krNsxqY25g XMnWxcjJISFgIvHu4DdGCFtM4sK99UBxLg4hgaWMEge3NrBCOM8YJWYv/QbWISyQJvHq7VNG kISIQCejxPeX2xkhqjYySsy40wZWxSwQIdH54BA7iM0mYCyxefkSoDgHB6+AlsTPMx4gYRYB VYm5/zaxgtiiQOWztv9gArF5BQQlfky+xwJicwo4Sez908sM0sosoCdx/6IWxHR5ic1r3jJP YBSYhaRjFkLVLCRVCxiZVzGKppYmFxQnpeca6hUn5haX5qXrJefnbmKExMOXHYyLj1kdYhTg YFTi4V0hmhwuxJpYVlyZe4hRgoNZSYS3ZBJQiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/cXe9D hATSE0tSs1NTC1KLYLJMHJxSDYwh8WtqxH/OTmXmWH6cvaq0zqrNvXV5xsViQwObCTqJx6bt vO24Y/eq0LbNrLaMv4X233w//+cyDd693ztPfFPtC5J71OkpnROVwaF8dl7Iyidua6p9jW5e 2mq00nt1xZlfef/Ptodw+u77+Ktjn+buNP801S+dGn8e7/tXp7taxCrqPOOKN5xKLMUZiYZa zEXFiQBkNCUXgwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 07:00 AM, Chris Lapa wrote: > From: Chris Lapa > > The max8903_charger.h file indicated that dcm and dok were not optional > when dc_valid is set. > > It makes sense to have dok as a compulsory pin when dc_valid is given. > However dcm can be optionally wired to a fixed level especially when the > circuit is configured for dc power exclusively. > > The previous implementation already allowed for this somewhat, however no > error was given if dok wasn't given whilst dc_valid was. > > The new implementation enforces dok presence when dc_valid is given. Whilst > allowing dcm to be optional. > > Signed-off-by: Chris Lapa > --- > drivers/power/max8903_charger.c | 23 ++++++++++------------- > include/linux/power/max8903_charger.h | 6 +++--- > 2 files changed, 13 insertions(+), 16 deletions(-) Code looks correct: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof