From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754936AbcFQIJt (ORCPT ); Fri, 17 Jun 2016 04:09:49 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35337 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbcFQIJp (ORCPT ); Fri, 17 Jun 2016 04:09:45 -0400 Subject: Re: [PATCH V2 33/63] clocksource/drivers/time-armada-370-xp: Convert init function to return error To: Jon Hunter , tglx@linutronix.de References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-34-git-send-email-daniel.lezcano@linaro.org> <5763A4F4.30102@nvidia.com> Cc: linux-kernel@vger.kernel.org, Stephen Warren , Thierry Reding , Alexandre Courbot , "open list:TEGRA ARCHITECTUR..." From: Daniel Lezcano Message-ID: <5763B047.1010903@linaro.org> Date: Fri, 17 Jun 2016 10:09:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5763A4F4.30102@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 09:21 AM, Jon Hunter wrote: > > On 16/06/16 22:26, Daniel Lezcano wrote: >> The init functions do not return any error. They behave as the following: >> >> - panic, thus leading to a kernel crash while another timer may work and >> make the system boot up correctly >> >> or >> >> - print an error and let the caller unaware if the state of the system >> >> Change that by converting the init functions to return an error conforming >> to the CLOCKSOURCE_OF_RET prototype. >> >> Proper error handling (rollback, errno value) will be changed later case >> by case, thus this change just return back an error or success in the init >> function. >> >> Signed-off-by: Daniel Lezcano >> --- >> drivers/clocksource/tegra20_timer.c | 28 ++++++++++++++++------------ >> 1 file changed, 16 insertions(+), 12 deletions(-) > > The $subject does not appear to match with the driver you are modifying > here. Ah, crap. I introduced a shift somewhere in the patchset. Fixed. Thanks ! -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog