From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754541AbcFQI7S (ORCPT ); Fri, 17 Jun 2016 04:59:18 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:40990 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337AbcFQI7Q (ORCPT ); Fri, 17 Jun 2016 04:59:16 -0400 X-AuditID: cbfec7f5-f792a6d000001302-34-5763bbe0efe9 Subject: Re: [RFC PATCH 13/15] memory: samsung: endian fixes for IO To: Matthew Leach , Ben Dooks References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-14-matthew@mattleach.net> Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pavel Fedin , Pankaj Dubey , linux-arm-kernel@lists.codethink.co.uk From: Krzysztof Kozlowski Message-id: <5763BBDF.106@samsung.com> Date: Fri, 17 Jun 2016 10:59:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160608183110.13851-14-matthew@mattleach.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t/xq7oPdieHGzw5p2Dx4FYrk8XrF4YW k/8uYLbY9Pgaq8XlXXPYLGac38dk0bh0GYvFq0ur2CwWbf3C7sDp8ezlZCaPhmtP2D02L6n3 mPphHYtH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZXz/f42x4Btvxc5bpQ2MF7i7GDk5JARM JHrmLGaGsMUkLtxbz9bFyMUhJLCUUeLfkxYo5xmjxMJ379hAqoQFnCUWf/rCCmKLCARIbDhy G8jmACrKkWhr1gKpZxZ4yChxbcMSFpAaNgFjic3Ll4D18gqoSfw91wi2jUVAVWLK9imMILao QITErO0/mCBqBCV+TL4H1sspYCPR8uMUG8h8ZgE9ifsXtUDCzALyEpvXvGWewCgwC0nHLISq WUiqFjAyr2IUTS1NLihOSs810itOzC0uzUvXS87P3cQICf2vOxiXHrM6xCjAwajEw7tCNDlc iDWxrLgy9xCjBAezkgivzA6gEG9KYmVValF+fFFpTmrxIUZpDhYlcd6Zu96HCAmkJ5akZqem FqQWwWSZODilGhjrA0qMlWtn7msWemcpwaJdfWPy/K8LhUvWLjFYdqgliG37Dammn07uvNNY P++ybJD09gqeyhrhVJu7WiRTJGpGnLTSXbspOT/4Lu/imeNhM9vXZsnO5FvfKmNZEia9tEq7 wFCWGec32W3m50UOynMPa+ZIJNbri1f8qFbm+M7obCNVeFKRTYmlOCPRUIu5qDgRAAwEEuB5 AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2016 08:31 PM, Matthew Leach wrote: > From: Ben Dooks > > Use the relaxed versions of the IO accessors to avoid any issues > if running in big endian. > > Signed-off-by: Ben Dooks > --- > Cc: Pavel Fedin > Cc: Krzysztof Kozlowski > Cc: Pankaj Dubey > Cc: linux-arm-kernel@lists.codethink.co.uk > --- > drivers/memory/samsung/exynos-srom.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c > index 96756fb..ac8f79c 100644 > --- a/drivers/memory/samsung/exynos-srom.c > +++ b/drivers/memory/samsung/exynos-srom.c > @@ -91,11 +91,11 @@ static int exynos_srom_configure_bank(struct exynos_srom *srom, > if (width == 2) > cs |= 1 << EXYNOS_SROM_BW__DATAWIDTH__SHIFT; > > - bw = __raw_readl(srom->reg_base + EXYNOS_SROM_BW); > + bw = readl_relaxed(srom->reg_base + EXYNOS_SROM_BW); > bw = (bw & ~(EXYNOS_SROM_BW__CS_MASK << bank)) | (cs << bank); > - __raw_writel(bw, srom->reg_base + EXYNOS_SROM_BW); > + writel_relaxed(bw, srom->reg_base + EXYNOS_SROM_BW); > > - __raw_writel(pmc | (timing[0] << EXYNOS_SROM_BCX__TACP__SHIFT) | > + writel_relaxed(pmc | (timing[0] << EXYNOS_SROM_BCX__TACP__SHIFT) | > (timing[1] << EXYNOS_SROM_BCX__TCAH__SHIFT) | > (timing[2] << EXYNOS_SROM_BCX__TCOH__SHIFT) | > (timing[3] << EXYNOS_SROM_BCX__TACC__SHIFT) | It breaks indentation of arguments. With that change and Matthew's SoB: Reviewed-by: Krzysztof Kozlowski I can take it through samsung-soc tree after fixing above. Best regards, Krzysztof